tisfc bugfix #2137
tisfc bugfix #2137
Conversation
|
So I went to edit the description on my PR 2016 and ended up editing yours on accident with the PR template were updating there. Please let me know if anything is confusing to fill out. Sorry |
@BrianCurtis-NOAA Are there instructions for test_changes.list? |
Todays PR 2016 once merged, each rt.sh run will generate test_changes.list which list the names of the failed tests and their compiler. This file will be empty at times if the PR changes no baselines. When developers run rt.sh for proving what tests the PR changes, that file will need to be committed to the repo. Then the CM's can use this file for baseline generation with |
|
@ShanSunNOAA Here is the list of tests that have failed. Please look through them and let me know if this list is consistent with the physics changes you made. 001 cpld_control_p8_mixedmode_intel failed in check_result |
|
@ShanSunNOAA Has anyone confirmed that this change is acting as expected for the standalone cases? I believe the reason those tests are changing has to do w/ the change being made for lake ice also. Is that right? |
jkbk2004
requested review from
barlage,
JessicaMeixner-NOAA,
yangfanglin and
JongilHan66
|
@JessicaMeixner-NOAA @yangfanglin @barlage This PR will change baselines including coupled cases. Grant attached evaluation slide decks. Can we get reviews? |
|
@SamuelTrahanNOAA @MichaelLueken FYI: regional cases get affected. |
|
Hi Grant,
Thank you for conducting all the regression tests. Is it possible to
identify which tests actually "passed" the regression test? I anticipate
that the hurricane runs without sea ice involvement will pass the
regression tests. Is that the case?
Thanks,
Shan
…On Wed, Feb 21, 2024 at 9:11 AM Grant Firl ***@***.***> wrote:
@ShanSunNOAA <https://github.com/ShanSunNOAA> Here is the list of tests
that have failed. Please look through them and let me know if this list is
consistent with the physics changes you made.
001 cpld_control_p8_mixedmode_intel failed in check_result
cpld_control_p8_mixedmode_intel 001 failed in run_test
002 cpld_control_gfsv17_intel failed in check_result
cpld_control_gfsv17_intel 002 failed in run_test
005 cpld_mpi_gfsv17_intel failed in check_result
cpld_mpi_gfsv17_intel 005 failed in run_test
006 cpld_debug_gfsv17_intel failed in check_result
cpld_debug_gfsv17_intel 006 failed in run_test
007 cpld_control_p8_intel failed in check_result
cpld_control_p8_intel 007 failed in run_test
008 cpld_control_p8.v2.sfc_intel failed in check_result
cpld_control_p8.v2.sfc_intel 008 failed in run_test
010 cpld_control_qr_p8_intel failed in check_result
cpld_control_qr_p8_intel 010 failed in run_test
012 cpld_2threads_p8_intel failed in check_result
cpld_2threads_p8_intel 012 failed in run_test
013 cpld_decomp_p8_intel failed in check_result
cpld_decomp_p8_intel 013 failed in run_test
014 cpld_mpi_p8_intel failed in check_result
cpld_mpi_p8_intel 014 failed in run_test
015 cpld_control_ciceC_p8_intel failed in check_result
cpld_control_ciceC_p8_intel 015 failed in run_test
016 cpld_control_c192_p8_intel failed in check_result
cpld_control_c192_p8_intel 016 failed in run_test
018 cpld_bmark_p8_intel failed in check_result
cpld_bmark_p8_intel 018 failed in run_test
020 cpld_s2sa_p8_intel failed in check_result
cpld_s2sa_p8_intel 020 failed in run_test
021 cpld_control_noaero_p8_intel failed in check_result
cpld_control_noaero_p8_intel 021 failed in run_test
022 cpld_control_nowave_noaero_p8_intel failed in check_result
cpld_control_nowave_noaero_p8_intel 022 failed in run_test
023 cpld_debug_p8_intel failed in check_result
cpld_debug_p8_intel 023 failed in run_test
024 cpld_debug_noaero_p8_intel failed in check_result
cpld_debug_noaero_p8_intel 024 failed in run_test
025 cpld_control_noaero_p8_agrid_intel failed in check_result
cpld_control_noaero_p8_agrid_intel 025 failed in run_test
026 cpld_control_c48_intel failed in check_result
cpld_control_c48_intel 026 failed in run_test
027 cpld_control_p8_faster_intel failed in check_result
cpld_control_p8_faster_intel 027 failed in run_test
028 cpld_control_pdlib_p8_intel failed in check_result
cpld_control_pdlib_p8_intel 028 failed in run_test
031 cpld_debug_pdlib_p8_intel failed in check_result
cpld_debug_pdlib_p8_intel 031 failed in run_test
032 control_flake_intel failed in check_result
control_flake_intel 032 failed in run_test
033 control_CubedSphereGrid_intel failed in check_result
control_CubedSphereGrid_intel 033 failed in run_test
034 control_CubedSphereGrid_parallel_intel failed in check_result
control_CubedSphereGrid_parallel_intel 034 failed in run_test
035 control_latlon_intel failed in check_result
control_latlon_intel 035 failed in run_test
036 control_wrtGauss_netcdf_parallel_intel failed in check_result
control_wrtGauss_netcdf_parallel_intel 036 failed in run_test
037 control_c48_intel failed in check_result
control_c48_intel 037 failed in run_test
038 control_c48.v2.sfc_intel failed in check_result
control_c48.v2.sfc_intel 038 failed in run_test
039 control_c192_intel failed in check_result
control_c192_intel 039 failed in run_test
040 control_c384_intel failed in check_result
control_c384_intel 040 failed in run_test
041 control_c384gdas_intel failed in check_result
control_c384gdas_intel 041 failed in run_test
042 control_stochy_intel failed in check_result
control_stochy_intel 042 failed in run_test
044 control_lndp_intel failed in check_result
control_lndp_intel 044 failed in run_test
045 control_iovr4_intel failed in check_result
control_iovr4_intel 045 failed in run_test
046 control_iovr5_intel failed in check_result
control_iovr5_intel 046 failed in run_test
047 control_p8_intel failed in check_result
control_p8_intel 047 failed in run_test
048 control_p8.v2.sfc_intel failed in check_result
control_p8.v2.sfc_intel 048 failed in run_test
049 control_p8_ugwpv1_intel failed in check_result
control_p8_ugwpv1_intel 049 failed in run_test
051 control_noqr_p8_intel failed in check_result
control_noqr_p8_intel 051 failed in run_test
053 control_decomp_p8_intel failed in check_result
control_decomp_p8_intel 053 failed in run_test
054 control_2threads_p8_intel failed in check_result
control_2threads_p8_intel 054 failed in run_test
055 control_p8_lndp_intel failed in check_result
control_p8_lndp_intel 055 failed in run_test
056 control_p8_rrtmgp_intel failed in check_result
control_p8_rrtmgp_intel 056 failed in run_test
057 control_p8_mynn_intel failed in check_result
control_p8_mynn_intel 057 failed in run_test
058 merra2_thompson_intel failed in check_result
merra2_thompson_intel 058 failed in run_test
067 rap_control_intel failed in check_result
rap_control_intel 067 failed in run_test
069 rap_decomp_intel failed in check_result
rap_decomp_intel 069 failed in run_test
070 rap_2threads_intel failed in check_result
rap_2threads_intel 070 failed in run_test
072 rap_sfcdiff_intel failed in check_result
rap_sfcdiff_intel 072 failed in run_test
073 rap_sfcdiff_decomp_intel failed in check_result
rap_sfcdiff_decomp_intel 073 failed in run_test
075 hrrr_control_intel failed in check_result
hrrr_control_intel 075 failed in run_test
076 hrrr_control_decomp_intel failed in check_result
hrrr_control_decomp_intel 076 failed in run_test
077 hrrr_control_2threads_intel failed in check_result
hrrr_control_2threads_intel 077 failed in run_test
079 rrfs_v1beta_intel failed in check_result
rrfs_v1beta_intel 079 failed in run_test
080 rrfs_v1nssl_intel failed in check_result
rrfs_v1nssl_intel 080 failed in run_test
081 rrfs_v1nssl_nohailnoccn_intel failed in check_result
rrfs_v1nssl_nohailnoccn_intel 081 failed in run_test
082 control_csawmg_intel failed in check_result
control_csawmg_intel 082 failed in run_test
083 control_csawmgt_intel failed in check_result
control_csawmgt_intel 083 failed in run_test
084 control_ras_intel failed in check_result
control_ras_intel 084 failed in run_test
085 control_wam_intel failed in check_result
control_wam_intel 085 failed in run_test
086 control_p8_faster_intel failed in check_result
control_p8_faster_intel 086 failed in run_test
088 control_CubedSphereGrid_debug_intel failed in check_result
control_CubedSphereGrid_debug_intel 088 failed in run_test
089 control_wrtGauss_netcdf_parallel_debug_intel failed in check_result
control_wrtGauss_netcdf_parallel_debug_intel 089 failed in run_test
090 control_stochy_debug_intel failed in check_result
control_stochy_debug_intel 090 failed in run_test
091 control_lndp_debug_intel failed in check_result
control_lndp_debug_intel 091 failed in run_test
092 control_csawmg_debug_intel failed in check_result
control_csawmg_debug_intel 092 failed in run_test
093 control_csawmgt_debug_intel failed in check_result
control_csawmgt_debug_intel 093 failed in run_test
094 control_ras_debug_intel failed in check_result
control_ras_debug_intel 094 failed in run_test
095 control_diag_debug_intel failed in check_result
control_diag_debug_intel 095 failed in run_test
096 control_debug_p8_intel failed in check_result
control_debug_p8_intel 096 failed in run_test
098 rap_control_debug_intel failed in check_result
rap_control_debug_intel 098 failed in run_test
099 hrrr_control_debug_intel failed in check_result
hrrr_control_debug_intel 099 failed in run_test
100 hrrr_gf_debug_intel failed in check_result
hrrr_gf_debug_intel 100 failed in run_test
101 hrrr_c3_debug_intel failed in check_result
hrrr_c3_debug_intel 101 failed in run_test
102 rap_unified_drag_suite_debug_intel failed in check_result
rap_unified_drag_suite_debug_intel 102 failed in run_test
103 rap_diag_debug_intel failed in check_result
rap_diag_debug_intel 103 failed in run_test
104 rap_cires_ugwp_debug_intel failed in check_result
rap_cires_ugwp_debug_intel 104 failed in run_test
105 rap_unified_ugwp_debug_intel failed in check_result
rap_unified_ugwp_debug_intel 105 failed in run_test
106 rap_lndp_debug_intel failed in check_result
rap_lndp_debug_intel 106 failed in run_test
107 rap_progcld_thompson_debug_intel failed in check_result
rap_progcld_thompson_debug_intel 107 failed in run_test
108 rap_noah_debug_intel failed in check_result
rap_noah_debug_intel 108 failed in run_test
109 rap_sfcdiff_debug_intel failed in check_result
rap_sfcdiff_debug_intel 109 failed in run_test
110 rap_noah_sfcdiff_cires_ugwp_debug_intel failed in check_result
rap_noah_sfcdiff_cires_ugwp_debug_intel 110 failed in run_test
111 rrfs_v1beta_debug_intel failed in check_result
rrfs_v1beta_debug_intel 111 failed in run_test
112 rap_clm_lake_debug_intel failed in check_result
rap_clm_lake_debug_intel 112 failed in run_test
113 rap_flake_debug_intel failed in check_result
rap_flake_debug_intel 113 failed in run_test
114 gnv1_c96_no_nest_debug_intel failed in check_result
gnv1_c96_no_nest_debug_intel 114 failed in run_test
115 control_wam_debug_intel failed in check_result
control_wam_debug_intel 115 failed in run_test
117 rap_control_dyn32_phy32_intel failed in check_result
rap_control_dyn32_phy32_intel 117 failed in run_test
118 hrrr_control_dyn32_phy32_intel failed in check_result
hrrr_control_dyn32_phy32_intel 118 failed in run_test
119 rap_2threads_dyn32_phy32_intel failed in check_result
rap_2threads_dyn32_phy32_intel 119 failed in run_test
120 hrrr_control_2threads_dyn32_phy32_intel failed in check_result
hrrr_control_2threads_dyn32_phy32_intel 120 failed in run_test
121 hrrr_control_decomp_dyn32_phy32_intel failed in check_result
hrrr_control_decomp_dyn32_phy32_intel 121 failed in run_test
124 conus13km_control_intel failed in check_result
conus13km_control_intel 124 failed in run_test
127 rap_control_dyn64_phy32_intel failed in check_result
rap_control_dyn64_phy32_intel 127 failed in run_test
128 rap_control_debug_dyn32_phy32_intel failed in check_result
rap_control_debug_dyn32_phy32_intel 128 failed in run_test
129 hrrr_control_debug_dyn32_phy32_intel failed in check_result
hrrr_control_debug_dyn32_phy32_intel 129 failed in run_test
130 conus13km_debug_intel failed in check_result
conus13km_debug_intel 130 failed in run_test
131 conus13km_debug_qr_intel failed in check_result
conus13km_debug_qr_intel 131 failed in run_test
132 conus13km_debug_2threads_intel failed in check_result
conus13km_debug_2threads_intel 132 failed in run_test
133 conus13km_radar_tten_debug_intel failed in check_result
conus13km_radar_tten_debug_intel 133 failed in run_test
134 rap_control_dyn64_phy32_debug_intel failed in check_result
rap_control_dyn64_phy32_debug_intel 134 failed in run_test
142 hafs_global_1nest_atm_intel failed in check_result
hafs_global_1nest_atm_intel 142 failed in run_test
143 hafs_global_multiple_4nests_atm_intel failed in check_result
hafs_global_multiple_4nests_atm_intel 143 failed in run_test
147 hafs_global_storm_following_1nest_atm_intel failed in check_result
hafs_global_storm_following_1nest_atm_intel 147 failed in run_test
148 gnv1_nested_intel failed in check_result
gnv1_nested_intel 148 failed in run_test
174 control_p8_atmlnd_sbs_intel failed in check_result
control_p8_atmlnd_sbs_intel 174 failed in run_test
175 control_p8_atmlnd_intel failed in check_result
control_p8_atmlnd_intel 175 failed in run_test
177 atmwav_control_noaero_p8_intel failed in check_result
atmwav_control_noaero_p8_intel 177 failed in run_test
178 control_atmwav_intel failed in check_result
control_atmwav_intel 178 failed in run_test
179 atmaero_control_p8_intel failed in check_result
atmaero_control_p8_intel 179 failed in run_test
180 atmaero_control_p8_rad_intel failed in check_result
atmaero_control_p8_rad_intel 180 failed in run_test
181 atmaero_control_p8_rad_micro_intel failed in check_result
atmaero_control_p8_rad_micro_intel 181 failed in run_test
183 control_c48_gnu failed in check_result
control_c48_gnu 183 failed in run_test
184 control_stochy_gnu failed in check_result
control_stochy_gnu 184 failed in run_test
185 control_ras_gnu failed in check_result
control_ras_gnu 185 failed in run_test
186 control_p8_gnu failed in check_result
control_p8_gnu 186 failed in run_test
187 control_p8_ugwpv1_gnu failed in check_result
control_p8_ugwpv1_gnu 187 failed in run_test
188 control_flake_gnu failed in check_result
control_flake_gnu 188 failed in run_test
189 rap_control_gnu failed in check_result
rap_control_gnu 189 failed in run_test
190 rap_decomp_gnu failed in check_result
rap_decomp_gnu 190 failed in run_test
191 rap_2threads_gnu failed in check_result
rap_2threads_gnu 191 failed in run_test
193 rap_sfcdiff_gnu failed in check_result
rap_sfcdiff_gnu 193 failed in run_test
194 rap_sfcdiff_decomp_gnu failed in check_result
rap_sfcdiff_decomp_gnu 194 failed in run_test
196 hrrr_control_gnu failed in check_result
hrrr_control_gnu 196 failed in run_test
197 hrrr_control_noqr_gnu failed in check_result
hrrr_control_noqr_gnu 197 failed in run_test
198 hrrr_control_2threads_gnu failed in check_result
hrrr_control_2threads_gnu 198 failed in run_test
199 hrrr_control_decomp_gnu failed in check_result
hrrr_control_decomp_gnu 199 failed in run_test
202 rrfs_v1beta_gnu failed in check_result
rrfs_v1beta_gnu 202 failed in run_test
203 control_diag_debug_gnu failed in check_result
control_diag_debug_gnu 203 failed in run_test
205 rap_control_debug_gnu failed in check_result
rap_control_debug_gnu 205 failed in run_test
206 hrrr_control_debug_gnu failed in check_result
hrrr_control_debug_gnu 206 failed in run_test
207 hrrr_gf_debug_gnu failed in check_result
hrrr_gf_debug_gnu 207 failed in run_test
208 hrrr_c3_debug_gnu failed in check_result
hrrr_c3_debug_gnu 208 failed in run_test
209 rap_diag_debug_gnu failed in check_result
rap_diag_debug_gnu 209 failed in run_test
210 rap_noah_sfcdiff_cires_ugwp_debug_gnu failed in check_result
rap_noah_sfcdiff_cires_ugwp_debug_gnu 210 failed in run_test
211 rap_progcld_thompson_debug_gnu failed in check_result
rap_progcld_thompson_debug_gnu 211 failed in run_test
212 rrfs_v1beta_debug_gnu failed in check_result
rrfs_v1beta_debug_gnu 212 failed in run_test
213 control_ras_debug_gnu failed in check_result
control_ras_debug_gnu 213 failed in run_test
214 control_stochy_debug_gnu failed in check_result
control_stochy_debug_gnu 214 failed in run_test
215 control_debug_p8_gnu failed in check_result
control_debug_p8_gnu 215 failed in run_test
216 rap_flake_debug_gnu failed in check_result
rap_flake_debug_gnu 216 failed in run_test
217 rap_clm_lake_debug_gnu failed in check_result
rap_clm_lake_debug_gnu 217 failed in run_test
218 gnv1_c96_no_nest_debug_gnu failed in check_result
gnv1_c96_no_nest_debug_gnu 218 failed in run_test
219 control_wam_debug_gnu failed in check_result
control_wam_debug_gnu 219 failed in run_test
220 rap_control_dyn32_phy32_gnu failed in check_result
rap_control_dyn32_phy32_gnu 220 failed in run_test
221 hrrr_control_dyn32_phy32_gnu failed in check_result
hrrr_control_dyn32_phy32_gnu 221 failed in run_test
222 rap_2threads_dyn32_phy32_gnu failed in check_result
rap_2threads_dyn32_phy32_gnu 222 failed in run_test
223 hrrr_control_2threads_dyn32_phy32_gnu failed in check_result
hrrr_control_2threads_dyn32_phy32_gnu 223 failed in run_test
224 hrrr_control_decomp_dyn32_phy32_gnu failed in check_result
hrrr_control_decomp_dyn32_phy32_gnu 224 failed in run_test
227 conus13km_control_gnu failed in check_result
conus13km_control_gnu 227 failed in run_test
230 rap_control_dyn64_phy32_gnu failed in check_result
rap_control_dyn64_phy32_gnu 230 failed in run_test
231 rap_control_debug_dyn32_phy32_gnu failed in check_result
rap_control_debug_dyn32_phy32_gnu 231 failed in run_test
232 hrrr_control_debug_dyn32_phy32_gnu failed in check_result
hrrr_control_debug_dyn32_phy32_gnu 232 failed in run_test
233 conus13km_debug_gnu failed in check_result
conus13km_debug_gnu 233 failed in run_test
234 conus13km_debug_qr_gnu failed in check_result
conus13km_debug_qr_gnu 234 failed in run_test
235 conus13km_debug_2threads_gnu failed in check_result
conus13km_debug_2threads_gnu 235 failed in run_test
236 conus13km_radar_tten_debug_gnu failed in check_result
conus13km_radar_tten_debug_gnu 236 failed in run_test
237 rap_control_dyn64_phy32_debug_gnu failed in check_result
rap_control_dyn64_phy32_debug_gnu 237 failed in run_test
238 cpld_control_p8_gnu failed in check_result
cpld_control_p8_gnu 238 failed in run_test
239 cpld_control_nowave_noaero_p8_gnu failed in check_result
cpld_control_nowave_noaero_p8_gnu 239 failed in run_test
240 cpld_debug_p8_gnu failed in check_result
cpld_debug_p8_gnu 240 failed in run_test
241 cpld_control_pdlib_p8_gnu failed in check_result
cpld_control_pdlib_p8_gnu 241 failed in run_test
242 cpld_debug_pdlib_p8_gnu failed in check_result
cpld_debug_pdlib_p8_gnu 242 failed in run_test
—
Reply to this email directly, view it on GitHub
<#2137 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ALORMVXEUQ6QS6VXZZO3V6TYUYFDFAVCNFSM6AAAAABDRTOYKOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSNJWHA4DONRXGI>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
--
Shan Sun, Ph.D. (she)
S2S Branch Chief
Earth Prediction Advancement Division
NOAA Global Systems Laboratory
Boulder, Colorado
|
|
@grantfirl It might be worthwhile to run after @BrianCurtis-NOAA PR for RT updating is done, so we can see how the new rt.sh would report these results. Hopefully it would be more clear than what is reported currently. |
|
I had email exchanges with Fanglin on the standalone atm. Since the
proposed changes are also utilized in the standalone atm, I'd expect the
standalone tests to fail, unless it is a regional model without sea ice
present.
Shan
…On Wed, Feb 21, 2024 at 10:50 AM Denise Worthen ***@***.***> wrote:
@ShanSunNOAA <https://github.com/ShanSunNOAA> Has anyone confirmed that
this change is acting as expected for the standalone tests? I believe the
reason those tests are changing has to do w/ the change being made for lake
ice also. Is that right?
—
Reply to this email directly, view it on GitHub
<#2137 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ALORMVW57MXHEFCO4PVDPELYUYQWJAVCNFSM6AAAAABDRTOYKOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSNJXGI3TOMBSHA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
--
Shan Sun, Ph.D. (she)
S2S Branch Chief
Earth Prediction Advancement Division
NOAA Global Systems Laboratory
Boulder, Colorado
|
|
@ShanSunNOAA From what I could see on the RT log, at least some rap tests passed. Three hafs tests did fail |
|
I wonder what the lat/lon are where the difference occurred in the hafs
model. I am attending the OSM meeting this week and may not get to it soon.
Thanks!
Shan
…On Wed, Feb 21, 2024 at 11:50 AM Denise Worthen ***@***.***> wrote:
@ShanSunNOAA <https://github.com/ShanSunNOAA> From what I could see on
the RT log, at least some rap tests passed. Three hafs tests did fail
7430:142 hafs_global_1nest_atm_intel failed in check_result
7432:143 hafs_global_multiple_4nests_atm_intel failed in check_result
7434:147 hafs_global_storm_following_1nest_atm_intel failed in check_result
—
Reply to this email directly, view it on GitHub
<#2137 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ALORMVWVSGSSGJOR6NZRYQ3YUYXWTAVCNFSM6AAAAABDRTOYKOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSNJXGUYDMMJRGI>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
--
Shan Sun, Ph.D. (she)
S2S Branch Chief
Earth Prediction Advancement Division
NOAA Global Systems Laboratory
Boulder, Colorado
|
|
@ShanSunNOAA I think the lake ice is impacted in your PR: |
|
For sanity check, we need to make a few plots to compare Tskin over sea-ice from RT runs before and after the updates. I did not see any "capping" of Tskin over sea-ice from existing atmos-only runs when the issue was first brought up. |
You can look in the committed RT log file (https://github.com/ufs-community/ufs-weather-model/blob/97143111ee3cbae2e472e6ab69fb58773d2ef8db/tests/logs/RegressionTests_hera.log) and search for PASS to see which tests actually passed. |
I'm happy to retest once #2061 is merged and I update this branch to the newly-merged code. |
|
Thanks for the info. If the model deals with any form of ice, whether it's
sea ice or lake ice, the results will be most likely to be different.
Shan
…On Wed, Feb 21, 2024 at 12:07 PM Jun Wang ***@***.***> wrote:
@ShanSunNOAA <https://github.com/ShanSunNOAA> I think the lake ice is
impacted in your PR:
https://github.com/ufs-community/ccpp-physics/pull/173/files#diff-54f7e6017510a256213583073ce068217912b52e9b426565bd10e47dfa4f15e1L190
—
Reply to this email directly, view it on GitHub
<#2137 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ALORMVUIYYAE7F4O6ZEKAIDYUYZVJAVCNFSM6AAAAABDRTOYKOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSNJXGU3DOMZSG4>
.
You are receiving this because you were mentioned.
|
|
Some notes on a few reg tests differences from baseline:
|
@DeniseWorthen @ShanSunNOAA FYI, I reran RTs after @BrianCurtis-NOAA update and committed the test_changes.list file. |
|
@grantfirl Can you sync up branch? There is a consensus difference of the cases from lake ice. We can start working on this pr. |
|
WCOSS2 is taking a little longer because of the prod switch. Had to sync baseline and sync up the inputs as well. The final comparison is being run currently. There is also a fix to rt.sh for the -b option i'll be pushing shortly. When the test_change.list is created on another machine than the one you are running on, the list of tests might contain tests that are not supported on your machine. The -b option had not handled this properly. The fixes will address this bug. |
|
Skipping Acorn as it's still unavailable. |
|
Ok sounds good, I'll get started with the merge process within the ccpp PR. |
|
@grantfirl the component PRs have been merged in, please go ahead and update your .gtimodules and hashes. Thank you |
|
@FernandoAndrade-NOAA I updated my branch and pushed, but the last commit is not showing up in this PR for some reason. You can go to my branch and see that the commit is there: grantfirl@969e240. It's just not showing up here. |
|
@FernandoAndrade-NOAA I wonder if it's related to the requested changes by @BrianCurtis-NOAA ? Are you seeing the same thing? I've never seen this behavior before, where the PR branch is updated but not reflected on the PR page. |
|
@grantfirl I am not sure if it is due to git synchronization issue. might be worth to wait a bit. |
|
@grantfirl I see some comments about the git sync issue from git community: tips. I don't know if it can help. |
|
looks good now |
Thanks for the tip. I just did this with other PRs and it did the trick for them. The same behavior was there too. |
Commit Queue Requirements:
PR Information
Description
Changes to physics code such that the ice model is used to determine the ice temperature over both sea ice and lake ice.
From @ShanSunNOAA:
This issue is identified here. The output from my experiment is here.
Commit Message
Priority with reasoning
UFSWM Blocking Dependencies
UFSWM Git Issues Addressed By This PR
Changes
Sub component (with Pull Request links)
Input data Changes
Regression Test Changes (Please commit test_changes.list):
Library updates
Testing Log: