Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update modulefiles for tier-2 systems for ESMF 8.1.0 bs 21 #191

Merged
merged 9 commits into from
Sep 1, 2020

Conversation

climbfuji
Copy link
Collaborator

@climbfuji climbfuji commented Aug 27, 2020

Description

  • Update modulefiles for cheyenne.{gnu,intel}, gaea.intel, jet.intel to use ESMF 8.1.0 bs21
  • Changemodulefile for hera.gnu so that it matches the tier-2 modulefiles

Issue(s) addressed

Code no longer compiles on tier-2 platforms after the ESMF 8.1.0 bs21 update was made for tier-1 platforms.

Testing

ufs-weather-model compiles and runs on all tier-2 platforms (gaea.intel, jet.intel, cheyenne.intel, cheyenne.gnu), on endeavor.intel and also on macOS with gcc+gfortran and clang+gfortran

Regression testing:

  • all tests pass on hera.gnu, hera.intel, wcoss_cray, wcoss_dell_p3, orion.intel; regression test log updated in the PR
  • extra credits: all tests pass on cheyenne.gnu; regression test log updated in the PR

Dependencies

@junwang-noaa
Copy link
Collaborator

junwang-noaa commented Aug 27, 2020 via email

@climbfuji
Copy link
Collaborator Author

Dom, do you have ESMF compiled in debug mode? In s2s, the debug mode test is using the ESMF lib compiled with debug mode, we may need to update ufs-weather debug test with that when we merging the two repoes.

No I haven't this wasn't necessary until now. The current NCEPLIBS-external and NCEPLIBS build do not support this functionality yet. Would we build everything (i.e. netCDF, ...) in DEBUG mode or "just" ESMF?

@junwang-noaa
Copy link
Collaborator

junwang-noaa commented Aug 27, 2020 via email

@climbfuji
Copy link
Collaborator Author

That is OK, I will only add fv3 module then. So far only ESMF is built with debug mode, it is important for s2s. I think it is good to have all the libs built in debug mode.

If that's really needed and there is a way to switch to different "-debug" modules, then I can accommodate this for ESMF only in NCEPLIBS-external easily and provide debug modules relatively quickly. I would defer compiling the entire stack in debug mode to when we/I switch to hpc-stack. I assume hpc-stack has an option to compile everything in debug mode.

@climbfuji
Copy link
Collaborator Author

@DusanJovic-NOAA @junwang-noaa this PR should be ready to test. I will run regression tests on hera.intel, hera.gnu, orion.intel.

.gitmodules Show resolved Hide resolved
@DusanJovic-NOAA DusanJovic-NOAA merged commit 63c4889 into ufs-community:develop Sep 1, 2020
epic-cicd-jenkins pushed a commit that referenced this pull request Apr 17, 2023
* Add rocoto to env for wcoss

* Update hash of regional workflow
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants