-
Notifications
You must be signed in to change notification settings - Fork 244
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Diagnostic 3D instantaneous cloud fractions added. #181
Diagnostic 3D instantaneous cloud fractions added. #181
Conversation
Eric, Would you please answer the questions in the PR template? Please describe what this PR is going to do, then the issue created on ufs-weathermodel, have you done any kind of testing? If there are any other subcomponnet PRs associated with this PR? |
Thanks. I just added the description.
…On 8/6/2020 1:37 PM, Jun Wang wrote:
Eric,
Would you please answer the questions in the PR template? Please
describe what this PR is going to do, then the issue created on
ufs-weathermodel, have you done any kind of testing? If there are any
other subcomponnet PRs associated with this PR?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#181 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ALQ75MO3WLZCJFUS4I33VODR7LS6XANCNFSM4PWZOUBA>.
|
I didn't run all of the RTs on hera. If you need me to do that please
remind me of the command to do this in the /tests directory. Is it
rt.sh -k *****, where I'm not sure what the **** would be. Then let me
know if I would need to git add and commit the log files and push them
to my branch. I can't recall all of those details. Also in the past, I
only needed to do that on hera.
Eric
…On 8/6/2020 1:37 PM, Jun Wang wrote:
Eric,
Would you please answer the questions in the PR template? Please
describe what this PR is going to do, then the issue created on
ufs-weathermodel, have you done any kind of testing? If there are any
other subcomponnet PRs associated with this PR?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#181 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ALQ75MO3WLZCJFUS4I33VODR7LS6XANCNFSM4PWZOUBA>.
|
The command is: ./rt.sh -fe rt.conf
Also please list and link the fv3 and ccpp PR number (like you did for
issue number)
On Thu, Aug 6, 2020 at 2:00 PM ericaligo-NOAA <notifications@github.com>
wrote:
… I didn't run all of the RTs on hera. If you need me to do that please
remind me of the command to do this in the /tests directory. Is it
rt.sh -k *****, where I'm not sure what the **** would be. Then let me
know if I would need to git add and commit the log files and push them
to my branch. I can't recall all of those details. Also in the past, I
only needed to do that on hera.
Eric
On 8/6/2020 1:37 PM, Jun Wang wrote:
>
> Eric,
>
> Would you please answer the questions in the PR template? Please
> describe what this PR is going to do, then the issue created on
> ufs-weathermodel, have you done any kind of testing? If there are any
> other subcomponnet PRs associated with this PR?
>
> —
> You are receiving this because you authored the thread.
> Reply to this email directly, view it on GitHub
> <
#181 (comment)>,
> or unsubscribe
> <
https://github.com/notifications/unsubscribe-auth/ALQ75MO3WLZCJFUS4I33VODR7LS6XANCNFSM4PWZOUBA
>.
>
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#181 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AI7D6TJHZ2ITEUP3EKEHXXLR7LVVJANCNFSM4PWZOUBA>
.
|
Thanks. Do I need to git commit any log files?
…On 8/6/2020 2:13 PM, Jun Wang wrote:
The command is: ./rt.sh -fe rt.conf
Also please list and link the fv3 and ccpp PR number (like you did for
issue number)
On Thu, Aug 6, 2020 at 2:00 PM ericaligo-NOAA ***@***.***>
wrote:
> I didn't run all of the RTs on hera. If you need me to do that please
> remind me of the command to do this in the /tests directory. Is it
> rt.sh -k *****, where I'm not sure what the **** would be. Then let me
> know if I would need to git add and commit the log files and push them
> to my branch. I can't recall all of those details. Also in the past, I
> only needed to do that on hera.
>
> Eric
>
> On 8/6/2020 1:37 PM, Jun Wang wrote:
> >
> > Eric,
> >
> > Would you please answer the questions in the PR template? Please
> > describe what this PR is going to do, then the issue created on
> > ufs-weathermodel, have you done any kind of testing? If there are any
> > other subcomponnet PRs associated with this PR?
> >
> > —
> > You are receiving this because you authored the thread.
> > Reply to this email directly, view it on GitHub
> > <
>
#181 (comment)>,
>
> > or unsubscribe
> > <
>
https://github.com/notifications/unsubscribe-auth/ALQ75MO3WLZCJFUS4I33VODR7LS6XANCNFSM4PWZOUBA
> >.
> >
>
> —
> You are receiving this because you commented.
> Reply to this email directly, view it on GitHub
>
<#181 (comment)>,
> or unsubscribe
>
<https://github.com/notifications/unsubscribe-auth/AI7D6TJHZ2ITEUP3EKEHXXLR7LVVJANCNFSM4PWZOUBA>
> .
>
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#181 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ALQ75MJT4ZLQX2S2AYY2GNTR7LXDHANCNFSM4PWZOUBA>.
|
I see a bunch of errors immediately:
+ ecflow_client --ping --host=hfe08 --port=3827
[18:15:40 6.8.2020] Request( --ping :Eric.Aligo@hfe08 ), Failed to
connect to hfe08:3827. A fter 2 attempts. Is the server running ?
+ not_running=1
+ [[ 1 -eq 1 ]]
+ echo 'ecflow_server is NOT running on hfe08:3827'
ecflow_server is NOT running on hfe08:3827
+ sh /scratch2/NCEPDEV/fv3-cam/Dusan.Jovic/ecflow/bin/ecflow_start.sh -p
3827
[18:15:42 6.8.2020] Request( --ping :Eric.Aligo@hfe08 ), Failed to
connect to hfe08:3827. A fter 2 attempts. Is the server running ?
grep: /home/Eric.Aligo/.ecflowrc/servers: No such file or directory
grep: /home/Eric.Aligo/.ecflow_ui/servers.txt: No such file or directory
/scratch2/NCEPDEV/fv3-cam/Dusan.Jovic/ecflow/bin/ecflow_start.sh: line
188: /home/Eric.Alig o/.ecflow_ui/servers.txt: No such file or directory
…On 8/6/2020 2:13 PM, Jun Wang wrote:
The command is: ./rt.sh -fe rt.conf
Also please list and link the fv3 and ccpp PR number (like you did for
issue number)
On Thu, Aug 6, 2020 at 2:00 PM ericaligo-NOAA ***@***.***>
wrote:
> I didn't run all of the RTs on hera. If you need me to do that please
> remind me of the command to do this in the /tests directory. Is it
> rt.sh -k *****, where I'm not sure what the **** would be. Then let me
> know if I would need to git add and commit the log files and push them
> to my branch. I can't recall all of those details. Also in the past, I
> only needed to do that on hera.
>
> Eric
>
> On 8/6/2020 1:37 PM, Jun Wang wrote:
> >
> > Eric,
> >
> > Would you please answer the questions in the PR template? Please
> > describe what this PR is going to do, then the issue created on
> > ufs-weathermodel, have you done any kind of testing? If there are any
> > other subcomponnet PRs associated with this PR?
> >
> > —
> > You are receiving this because you authored the thread.
> > Reply to this email directly, view it on GitHub
> > <
>
#181 (comment)>,
>
> > or unsubscribe
> > <
>
https://github.com/notifications/unsubscribe-auth/ALQ75MO3WLZCJFUS4I33VODR7LS6XANCNFSM4PWZOUBA
> >.
> >
>
> —
> You are receiving this because you commented.
> Reply to this email directly, view it on GitHub
>
<#181 (comment)>,
> or unsubscribe
>
<https://github.com/notifications/unsubscribe-auth/AI7D6TJHZ2ITEUP3EKEHXXLR7LVVJANCNFSM4PWZOUBA>
> .
>
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#181 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ALQ75MJT4ZLQX2S2AYY2GNTR7LXDHANCNFSM4PWZOUBA>.
|
Not yet. If you do, you'll get merge conflict later when you merge your branch with develop. You can attach log from Hera to this PR if you want. |
This is because it's the first time you are running ecflow on this host. The regression test script should continue to run. |
+ set -e
+ ECFLOW_RUNNING=true
+ export ECF_PORT
+ export ECF_HOST
+ ecflow_client
--load=/scratch2/NCEPDEV/fv3-cam/save/Eric.Aligo/ufs-weather-model/tests/ec
flow_run/regtest_106075.def
+ ecflow_client --begin=regtest_106075
+ active_tasks=1
+ [[ 1 -ne 0 ]]
+ wait 109510
+ sleep 10
++ ecflow_client --get_state /regtest_106075
++ wc -l
++ grep 'task '
++ grep -E 'state:active|state:submitted|state:queued'
+ active_tasks=57
+ echo 'ecflow tasks remaining: 57'
ecflow tasks remaining: 57
+
/scratch2/NCEPDEV/fv3-cam/save/Eric.Aligo/ufs-weather-model/tests/abort_dep_tasks.py
Will force aborted state for task /regtest_106075/fv3_ccpp_control_prod
Will force aborted state for task /regtest_106075/fv3_ccpp_decomp_prod
Will force aborted state for task /regtest_106075/fv3_ccpp_2threads_prod
Will force aborted state for task /regtest_106075/fv3_ccpp_restart_prod
Will force aborted state for task /regtest_106075/fv3_ccpp_read_inc_prod
Will force aborted state for task
/regtest_106075/fv3_ccpp_wrtGauss_netcdf_esmf_prod
Will force aborted state for task
/regtest_106075/fv3_ccpp_wrtGauss_netcdf_prod
Will force aborted state for task
/regtest_106075/fv3_ccpp_wrtGlatlon_netcdf_prod
Will force aborted state for task
/regtest_106075/fv3_ccpp_wrtGauss_nemsio_prod
Will force aborted state for task
/regtest_106075/fv3_ccpp_wrtGauss_nemsio_c192_prod
Will force aborted state for task /regtest_106075/fv3_ccpp_stochy_prod
Will force aborted state for task /regtest_106075/fv3_ccpp_iau_prod
Will force aborted state for task /regtest_106075/fv3_ccpp_ca_prod
Will force aborted state for task /regtest_106075/fv3_ccpp_lheatstrg_prod
Will force aborted state for task /regtest_106075/fv3_ccpp_gfdlmprad_prod
Will force aborted state for task
/regtest_106075/fv3_ccpp_gfdlmprad_atmwav_prod
Will force aborted state for task
/regtest_106075/fv3_ccpp_wrtGauss_nemsio_c768_prod
Will force aborted state for task /regtest_106075/fv3_ccpp_multigases_prod
Will force aborted state for task
/regtest_106075/fv3_ccpp_control_32bit_prod
Will force aborted state for task /regtest_106075/fv3_ccpp_stretched_prod
Will force aborted state for task
/regtest_106075/fv3_ccpp_stretched_nest_prod
Will force aborted state for task
/regtest_106075/fv3_ccpp_regional_control_prod
Will force aborted state for task
/regtest_106075/fv3_ccpp_regional_restart_prod
Will force aborted state for task
/regtest_106075/fv3_ccpp_regional_quilt_prod
Will force aborted state for task
/regtest_106075/fv3_ccpp_regional_c768_prod
Will force aborted state for task
/regtest_106075/fv3_ccpp_control_debug_prod
Will force aborted state for task
/regtest_106075/fv3_ccpp_stretched_nest_debug_prod
Will force aborted state for task /regtest_106075/fv3_ccpp_gfdlmp_prod
Will force aborted state for task
/regtest_106075/fv3_ccpp_gfdlmprad_gwd_prod
Will force aborted state for task
/regtest_106075/fv3_ccpp_gfdlmprad_noahmp_prod
Will force aborted state for task
/regtest_106075/fv3_ccpp_gfdlmp_hwrfsas_prod
Will force aborted state for task /regtest_106075/fv3_ccpp_csawmg_prod
Will force aborted state for task /regtest_106075/fv3_ccpp_satmedmf_prod
Will force aborted state for task /regtest_106075/fv3_ccpp_satmedmfq_prod
Will force aborted state for task /regtest_106075/fv3_ccpp_gfdlmp_32bit_prod
Will force aborted state for task
/regtest_106075/fv3_ccpp_gfdlmprad_32bit_post_prod
Will force aborted state for task /regtest_106075/fv3_ccpp_cpt_prod
Will force aborted state for task /regtest_106075/fv3_ccpp_gsd_prod
Will force aborted state for task /regtest_106075/fv3_ccpp_rap_prod
Will force aborted state for task /regtest_106075/fv3_ccpp_hrrr_prod
Will force aborted state for task /regtest_106075/fv3_ccpp_thompson_prod
Will force aborted state for task
/regtest_106075/fv3_ccpp_thompson_no_aero_prod
Will force aborted state for task /regtest_106075/fv3_ccpp_rrfs_v1beta_prod
Will force aborted state for task /regtest_106075/fv3_ccpp_gfs_v15p2_prod
Will force aborted state for task /regtest_106075/fv3_ccpp_gfs_v16beta_prod
Will force aborted state for task /regtest_106075/fv3_ccpp_rrtmgp_prod
Will force aborted state for task
/regtest_106075/fv3_ccpp_gfs_v15p2_debug_prod
Will force aborted state for task
/regtest_106075/fv3_ccpp_gfs_v16beta_debug_prod
Will force aborted state for task /regtest_106075/fv3_ccpp_rrtmgp_debug_prod
Will force aborted state for task /regtest_106075/fv3_ccpp_gsd_debug_prod
Will force aborted state for task
/regtest_106075/fv3_ccpp_gsd_diag3d_debug_prod
Will force aborted state for task
/regtest_106075/fv3_ccpp_thompson_debug_prod
Will force aborted state for task
/regtest_106075/fv3_ccpp_thompson_no_aero_debug_prod
Will force aborted state for task
/regtest_106075/fv3_ccpp_gfsv16_csawmg_prod
Will force aborted state for task
/regtest_106075/fv3_ccpp_gfsv16_csawmgt_prod
Will force aborted state for task /regtest_106075/fv3_ccpp_gocart_clm_prod
Will force aborted state for task
/regtest_106075/fv3_ccpp_gfs_v16beta_flake_prod
+ [[ 57 -ne 0 ]]
+ wait 109742
+ sleep 10
++ ecflow_client --get_state /regtest_106075
++ grep 'task '
++ grep -E 'state:active|state:submitted|state:queued'
++ wc -l
+ active_tasks=0
+ echo 'ecflow tasks remaining: 0'
ecflow tasks remaining: 0
+
/scratch2/NCEPDEV/fv3-cam/save/Eric.Aligo/ufs-weather-model/tests/abort_dep_tasks.py
+ [[ 0 -ne 0 ]]
+ sleep 65
+ ecflow_client --delete=yes /regtest_106075
+ sleep 5
+ set +e
+ cat
/scratch2/NCEPDEV/fv3-cam/save/Eric.Aligo/ufs-weather-model/tests/log_hera.intel/compile_1.log
/scratch2/NCEPDEV/fv3-cam/save/Eric.Aligo/ufs-wle_10.log
/scratch2/NCEPDEV/fv3-cam/save/Eric.Aligo/ufs-weather-model/tests/log_hera.intel/compile_11.log
/scratch2/NCEPDEV/fv3-cam/save/Eric.Aligo/compile_12.log
/scratch2/NCEPDEV/fv3-cam/save/Eric.Aligo/ufs-weather-model/tests/log_hera.intel/compile_13.log
/scratch2/NCEPDEV/fv3-cam/save/Eric.Antel/compile_14.log
/scratch2/NCEPDEV/fv3-cam/save/Eric.Aligo/ufs-weather-model/tests/log_hera.intel/compile_2.log
/scratch2/NCEPDEV/fv3-cam/save/Erra.intel/compile_3.log
/scratch2/NCEPDEV/fv3-cam/save/Eric.Aligo/ufs-weather-model/tests/log_hera.intel/compile_4.log
/scratch2/NCEPDEV/fv3-cam/save_hera.intel/compile_5.log
/scratch2/NCEPDEV/fv3-cam/save/Eric.Aligo/ufs-weather-model/tests/log_hera.intel/compile_6.log
/scratch2/NCEPDEV/fv3-cam/slog_hera.intel/compile_7.log
/scratch2/NCEPDEV/fv3-cam/save/Eric.Aligo/ufs-weather-model/tests/log_hera.intel/compile_8.log
/scratch2/NCEPDEV/fv3-cats/log_hera.intel/compile_9.log
+ cat
'/scratch2/NCEPDEV/fv3-cam/save/Eric.Aligo/ufs-weather-model/tests/log_hera.intel/rt_*.log'
cat:
/scratch2/NCEPDEV/fv3-cam/save/Eric.Aligo/ufs-weather-model/tests/log_hera.intel/rt_*.log:
No such file or directory
++ echo 'rt.sh error on line 780'
rt.sh error on line 780
++ cleanup
++ [[ true == true ]]
++ ecflow_stop
++ [[ true == true ]]
++ set +e
+++ ecflow_client --get
+++ grep '^suite'
++ SUITES=
++ echo SUITES=
SUITES=
++ '[' -z '' ']'
++ ecflow_client --halt=yes
++ ecflow_client --check_pt
++ ecflow_client --terminate=yes
++ rm -rf
/scratch2/NCEPDEV/fv3-cam/save/Eric.Aligo/ufs-weather-model/tests/lock
++ trap 0
++ exit
…On 8/6/2020 2:26 PM, Dusan Jovic wrote:
I see a bunch of errors immediately: + ecflow_client --ping
--host=hfe08 --port=3827 [18:15:40 6.8.2020] Request( --ping
***@***.*** ), Failed to connect to hfe08:3827. A fter 2
attempts. Is the server running ? + not_running=1 + [[ 1 -eq 1 ]]
+ echo 'ecflow_server is NOT running on hfe08:3827' ecflow_server
is NOT running on hfe08:3827 + sh
/scratch2/NCEPDEV/fv3-cam/Dusan.Jovic/ecflow/bin/ecflow_start.sh
-p 3827 [18:15:42 6.8.2020] Request( --ping ***@***.*** ),
Failed to connect to hfe08:3827. A fter 2 attempts. Is the server
running ? grep: /home/Eric.Aligo/.ecflowrc/servers: No such file
or directory grep: /home/Eric.Aligo/.ecflow_ui/servers.txt: No
such file or directory
/scratch2/NCEPDEV/fv3-cam/Dusan.Jovic/ecflow/bin/ecflow_start.sh:
line 188: /home/Eric.Alig o/.ecflow_ui/servers.txt: No such file
or directory
… <#>
On 8/6/2020 2:13 PM, Jun Wang wrote: The command is: ./rt.sh -fe
rt.conf Also please list and link the fv3 and ccpp PR number (like
you did for issue number) On Thu, Aug 6, 2020 at 2:00 PM
ericaligo-NOAA /*@*/.***> wrote: > I didn't run all of the RTs on
hera. If you need me to do that please > remind me of the command
to do this in the /tests directory. Is it > rt.sh -k *****, where
I'm not sure what the **** would be. Then let me > know if I would
need to git add and commit the log files and push them > to my
branch. I can't recall all of those details. Also in the past, I >
only needed to do that on hera. > > Eric > > On 8/6/2020 1:37 PM,
Jun Wang wrote: > > > > Eric, > > > > Would you please answer the
questions in the PR template? Please > > describe what this PR is
going to do, then the issue created on > > ufs-weathermodel, have
you done any kind of testing? If there are any > > other
subcomponnet PRs associated with this PR? > > > > — > > You are
receiving this because you authored the thread. > > Reply to this
email directly, view it on GitHub > > < > #181 (comment)
<#181 (comment)>>,
> > > or unsubscribe > > < >
https://github.com/notifications/unsubscribe-auth/ALQ75MO3WLZCJFUS4I33VODR7LS6XANCNFSM4PWZOUBA
<https://github.com/notifications/unsubscribe-auth/ALQ75MO3WLZCJFUS4I33VODR7LS6XANCNFSM4PWZOUBA>
> >. > > > > — > You are receiving this because you commented. >
Reply to this email directly, view it on GitHub > <#181 (comment)
<#181 (comment)>>,
> or unsubscribe >
https://github.com/notifications/unsubscribe-auth/AI7D6TJHZ2ITEUP3EKEHXXLR7LVVJANCNFSM4PWZOUBA
<https://github.com/notifications/unsubscribe-auth/AI7D6TJHZ2ITEUP3EKEHXXLR7LVVJANCNFSM4PWZOUBA>
> . > — You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub <#181 (comment)
<#181 (comment)>>,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ALQ75MJT4ZLQX2S2AYY2GNTR7LXDHANCNFSM4PWZOUBA
<https://github.com/notifications/unsubscribe-auth/ALQ75MJT4ZLQX2S2AYY2GNTR7LXDHANCNFSM4PWZOUBA>.
This is because it's the first time you are running ecflow on this
host. The regression test script should continue to run.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#181 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ALQ75MM6S35GZXXMEKRGYT3R7LYWTANCNFSM4PWZOUBA>.
|
Were compiles successful? When compile fails, all runs are automatically aborted by ecflow. Check to see if you have *.exe files in the ufs-weather-model/tests directory. |
.gitmodules
Outdated
@@ -1,6 +1,6 @@ | |||
[submodule "FV3"] | |||
path = FV3 | |||
url = https://github.com/NOAA-EMC/fv3atm | |||
url = https://github.com/NOAA-EMC/fv3atm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove the space
Description
(Instructions: this, and all subsequent sections of text should be removed and filled in as appropriate.)
Diagnostic cldfra array outputs 3D instantaneous cloud fractions. Works with WSM6, Thompson and GFDL mp schemes. No results changed.
UPDATE: Provided a bug fix to GFS_restart.F90 with an if condition added in the ifdef CCPP block to test for reflectivity flag. RTs have been updated. Test run in 3-km FV3 LAM was successful and plots looked good.
Issue(s) addressed
#158
NOAA-EMC/fv3atm#154
NCAR/ccpp-physics#484
Testing
How were these changes tested?
Tested on hera with the SAR configuration. Evaluated fields from run with Thompson microphyics and GFDL microphysics.
Full RTs performed on hera.
Dependencies
FV3
ccpp/physics