Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow HAFS app to be compiled with 64bit FMS #1610

Closed

Conversation

DusanJovic-NOAA
Copy link
Collaborator

@DusanJovic-NOAA DusanJovic-NOAA commented Feb 13, 2023

Description

The HAFSW application with moving nest cannot be built with the 64bit FMS library.

The 64bit FMS is required for the mixed-mode HAFS-MOM6. The 64bit FMS is also required for the HAFS-MOM6 with moving nest.

Top of commit queue on: TBD

Input data additions/changes

  • No changes are expected to input data.
  • There will be new input data.
  • Input data will be updated.

Anticipated changes to regression tests:

  • No changes are expected to any regression test.
  • Changes are expected to the following tests:

Subcomponents involved:

  • AQM
  • CDEPS
  • CICE
  • CMEPS
  • CMakeModules
  • FV3
  • GOCART
  • HYCOM
  • MOM6
  • NOAHMP
  • WW3
  • stochastic_physics
  • none

Combined with PR's (If Applicable):

Commit Queue Checklist:

  • Link PR's from all sub-components involved
  • Confirm reviews completed in sub-component PR's
  • Add all appropriate labels to this PR.
  • Run full RT suite on either Hera/Cheyenne with both Intel/GNU compilers
  • Add list of any failed regression tests to "Anticipated changes to regression tests" section.

Linked PR's and Issues:

Testing Day Checklist:

  • This PR is up-to-date with the top of all sub-component repositories except for those sub-components which are the subject of this PR.
  • Move new/updated input data on RDHPCS Hera and propagate input data changes to all supported systems.

Testing Log (for CM's):

  • RDHPCS
    • Intel
      • Hera
      • Orion
      • Jet
      • Gaea
      • Cheyenne
    • GNU
      • Hera
      • Cheyenne
  • WCOSS2
    • Dogwood/Cactus
    • Acorn
  • CI
    • Completed
  • opnReqTest
    • N/A
    • Log attached to comment

@BrianCurtis-NOAA BrianCurtis-NOAA added the No Baseline Change No Baseline Change label Feb 17, 2023
@BrianCurtis-NOAA
Copy link
Collaborator

@DusanJovic-NOAA Can you attach to the PR comments the GNU and Intel logs showing that all tests pass current baselines?

@DusanJovic-NOAA
Copy link
Collaborator Author

@DusanJovic-NOAA Can you attach to the PR comments the GNU and Intel logs showing that all tests pass current baselines?

Regression tests (intel and gnu) passed on Hera.

RegressionTests_hera.gnu.log
RegressionTests_hera.intel.log

@BrianCurtis-NOAA BrianCurtis-NOAA added the Ready for Commit Queue The PR is ready for the Commit Queue. All checkboxes in PR template have been checked. label Feb 20, 2023
@jkbk2004
Copy link
Collaborator

jkbk2004 commented Mar 3, 2023

@DusanJovic-NOAA can you sync up fv3 branch? We may combine this pr to #1578. @SadeghTabas-NOAA can point to the fv3 branch.

@DusanJovic-NOAA
Copy link
Collaborator Author

@DusanJovic-NOAA can you sync up fv3 branch? We may combine this pr to #1578. @SadeghTabas-NOAA can point to the fv3 branch.

I just synced my fv3atm branch

@DeniseWorthen
Copy link
Collaborator

Committed with PR #1578

@DusanJovic-NOAA DusanJovic-NOAA deleted the hafs_64bit_fms branch August 31, 2023 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
No Baseline Change No Baseline Change Ready for Commit Queue The PR is ready for the Commit Queue. All checkboxes in PR template have been checked.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The HAFSW application with moving-nest needs to be built with the 64bit FMS library
6 participants