Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update global regression tests for RAP (formerly GSL) physics #952

Closed
climbfuji opened this issue Dec 10, 2021 · 0 comments · Fixed by #937
Closed

Update global regression tests for RAP (formerly GSL) physics #952

climbfuji opened this issue Dec 10, 2021 · 0 comments · Fixed by #937
Labels
enhancement New feature or request

Comments

@climbfuji
Copy link
Collaborator

Description

The GSL regression tests still use the old C96L64 input data from GFS v15. The tests must be updated to use the new C96L127 GFS v16 input data. Also, the tests should all be renamed to remove the institution (GSD, GSL) from the name and base it on an application/model (RAP in this case).

This will be done together with an update to several of the RAP physics from the NOAA-GSL gsl/develop forks of the ufs-weather-model, fv3atm, ccpp-physics.

@climbfuji climbfuji added the enhancement New feature or request label Dec 10, 2021
JianpingHuang-NOAA pushed a commit to JianpingHuang-NOAA/ufs-weather-model that referenced this issue Apr 21, 2024
* Restore ecflow workflow in AQM package

* Management authorized to remove hardwired workflow generation solution from developer on 10/17/2023.
Remove unnecessary ecflow template directory.
Fix issue where it hardwired job in ecflow workflow.
Remove incorrect configuration in ecflow script.
Move configuration directory into acceptable NCO code delivery location.

* Fixed bug for bias_correction and post_stat jobs
Fixed DBNALERT bug
Fixed wrong DO_AQM_SAVE_AIRNOW_HIST setting for NCO operation job
Fixed issue found in var_defns.sh where some parameter failed to export
Remove wrong parm/ecflow directory

* AQM ecflow workflow related change

* The current AQM implementation package has the architecture design that some jobs access DATA (stmp) from previous jobs.
It was communicated to the management that this design may not be acceptable to NCO.
However, ecflow workflow development is based on the current implementation package. The following change is needed to run jobs.
Modify aqm_cycled.def to use NCO production job naming format.
Modify aqm_cycled.def to use time based trigger requested from the AQM project manager.
Configure log file name for job nexus_gfs_sfc.

EX-script for Job exregional_make_ics.sh exregional_make_lbcs.sh exregional_nexus_emission.sh exregional_run_post.sh are designed with following issue:
1. Access the DATA (stmp) location from the previous job by hardwire wrong DATA directory name in ex-script.
2. No exception handling if the DATA directory is not found in nco production mode.
These four files have been fixed here by updating DATA location with ecflow job name and exception handling to fail the job if DATA is not found.

* The current AQM implementation package is designed for some jobs to access input files from other jobs' DATA (stmp) location.
These DATA directories can not be removed after current job finish with normal KEEPDATA=YES setting in the NCO production system.
These DATA directory names are hardwired with names that are not unique.
This solution is likely unacceptable to NCO production standards. This fact is communicated to the management.
However, ecflow workflow needs to be based on the current implementation package.
The data_cleanup job is designed to cleanup the following hardwired DATA directories:

* EE2 review for ecflow workflow

* parm/config is removed

* Add package configuration template files in parm/config

* Document configuration setup script
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
1 participant