production/GFSv16: check all compile option failed for GFSv16 atmospere model

[junwang-noaa]

Description

NCO requires to test "-check all" option with GFSv16 optimization mode (FFLAGS_OPT). GDAS ENKF, GADS forecast, GFS forecast Model failed with the executable built with the "-check all" option.

To Reproduce:

Checked out the GFS.v16.0.15 tag and add "-check all,noarg_temp_created" in FFLAGS_OPT compile options, then run GFS parallel test on wcoss, the run will fail with error message:
"forrtl: severe (408): fort: (8): Attempt to fetch from allocatable variable DTDT_M when it is not allocated
ERR=152"

bugzilla ticket is #1204.

Fixes will be made to production/GFSv16 branch for future GFS minor upgrades.

[junwang-noaa]

When compiling with "-check all,noarg_temp_created,nopointer", the GFS forecast can run until the wall clock is reached.

[climbfuji]

This dtdt_m issue was raised more than a year ago in the NOAA-EMC GFDL_atmos_cubed_sphere fork: NOAA-EMC/GFDL_atmos_cubed_sphere#29

I closed the issue after removing the IPD code, because the CCPP code doesn't have the problem, and since issues generally related to dev/emc on that fork. But GFSv16 is using IPD, which still has the issue.

I also discussed this with @bensonr last week.

[junwang-noaa]

@bensonr <https://github.com/bensonr> We may still need to allocate the dtdt_m without the if statement of "if ( idiag%id_mdt > 0 .and. (.not.do_adiabatic_init) ) then" (line #384 in FV3/atmos_cubed_sphere/model/fv_dynamics.F90), if there is no other simpler way to fix the error.

…

On Wed, Mar 10, 2021 at 10:05 AM Dom Heinzeller ***@***.***> wrote: This dtdt_m issue was raised more than a year ago in the NOAA-EMC GFDL_atmos_cubed_sphere fork: NOAA-EMC/GFDL_atmos_cubed_sphere#29 <NOAA-EMC/GFDL_atmos_cubed_sphere#29> I closed the issue after removing the IPD code, because the CCPP code doesn't have the problem, and since issues generally related to dev/emc on that fork. But GFSv16 is using IPD, which still has the issue. I also discussed this with @bensonr <https://github.com/bensonr> last week. — You are receiving this because you were assigned. Reply to this email directly, view it on GitHub <#455 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AI7D6TMVIIFGTR2AASKVMGLTC54BVANCNFSM4YZ2XD6A> .

[junwang-noaa]

The code changes (-check all,noarg_temp_created,nopointer) was committed to production branch, close this issue.