Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add nemsio file type for GDAS dataset #582

Closed
EdwardSnyder-NOAA opened this issue Feb 6, 2023 · 1 comment · Fixed by #718
Closed

Add nemsio file type for GDAS dataset #582

EdwardSnyder-NOAA opened this issue Feb 6, 2023 · 1 comment · Fixed by #718
Assignees
@EdwardSnyder-NOAA
Labels
enhancement New feature or request

Comments

@EdwardSnyder-NOAA
Copy link
Collaborator

EdwardSnyder-NOAA commented Feb 6, 2023 •
edited
Loading

Description

Add logic to handle GDAS nemsio dataset. Currently, netcdf is the only valid file type for GDAS data.

Solution

  • Modify the make_ics and make_lbc scripts to handle nemsio as an input type.
  • Update any additional files as needed.

Requirements**

Ensure the changes don't break the existing functionality of the ICS/LBCS workflow steps.

Acceptance Criteria (Definition of Done)

  • ICS can handle GDAS nemsio (atm+sfc files) and netcdf file types as well the existing model options (FV3GFS, HRRR, etc.)
  • LBCS can handle GDAS nemsio (atm file) and netcdf file types as well the existing model options (FV3GFS, HRRR, etc.)
@EdwardSnyder-NOAA EdwardSnyder-NOAA added the enhancement New feature or request label Feb 6, 2023
@EdwardSnyder-NOAA EdwardSnyder-NOAA mentioned this issue Apr 10, 2023
Merged
37 tasks
@EdwardSnyder-NOAA EdwardSnyder-NOAA self-assigned this Apr 10, 2023
@EdwardSnyder-NOAA
Copy link
Collaborator Author

Draft PR has been made #718

@christinaholtNOAA christinaholtNOAA moved this from Todo to In Progress in RRFS Merge to SRW Apr 10, 2023
@MichaelLueken MichaelLueken linked a pull request Apr 11, 2023 that will close this issue
[develop] Add GDAS nemsio data type for initial conditions #718
Merged
37 tasks
@github-project-automation github-project-automation bot moved this from In Progress to Done in RRFS Merge to SRW Apr 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@EdwardSnyder-NOAA EdwardSnyder-NOAA

Labels
enhancement New feature or request
Projects
No open projects
RRFS Merge to SRW
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[develop] Add GDAS nemsio data type for initial conditions EdwardSnyder-NOAA/ufs-srweather-app
1 participant
@EdwardSnyder-NOAA