Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Community Convective Cloud (C3) scheme #73

Merged
merged 4 commits into from
Jun 26, 2023

Conversation

haiqinli
Copy link
Collaborator

  1. Name the new unified convective parameterization as "Community Convective Cloud (c3) parameterization";
  2. Update the aerosol-aware for GF;
  3. Merge the aerosol-aware and RRFS configuration from GF into C3;

Copy link
Collaborator

@dustinswales dustinswales left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work. Just a few small comments.

physics/cu_gf_deep.F90 Outdated Show resolved Hide resolved
physics/cu_gf_deep.F90 Outdated Show resolved Hide resolved
physics/cu_gf_deep.F90 Outdated Show resolved Hide resolved
physics/cu_c3_deep.F90 Outdated Show resolved Hide resolved
physics/cu_gf_deep.F90 Outdated Show resolved Hide resolved
Copy link
Collaborator

@grantfirl grantfirl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, @haiqinli .

Copy link
Collaborator

@Qingfu-Liu Qingfu-Liu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good

@grantfirl
Copy link
Collaborator

@dustinswales Since you requested changes, please re-review and approve if your comments were adequately addressed.

@grantfirl
Copy link
Collaborator

@haiqinli Please pull down the top of the ufs/dev branch and merge it into this branch. Afterward, do the same for fv3atm and ufs-weather-model. When you do fv3atm, be sure to do git add ccpp/physics to update the ccpp-physics submodule pointer and when you do ufs-weather-model, be sure to git add FV3 to update the fv3atm submodule pointer.

@haiqinli
Copy link
Collaborator Author

@grantfirl Thank you very much for your suggestions. I have synced the ccpp/physics, fv3atm, and ufs-weather-model accordingly. I am redoing a regression test, and will update when it is done.

@jkbk2004
Copy link

All tests ran ok on ufs-community/ufs-weather-model#1795. @grantfirl @dustinswales can you go ahead to merge in this pr?

@grantfirl grantfirl merged commit 427c77b into ufs-community:ufs/dev Jun 26, 2023
grantfirl pushed a commit that referenced this pull request Jul 18, 2023
@haiqinli haiqinli deleted the ufs/dev-c3 branch September 15, 2023 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants