Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Coupling Merra2 aerosol climatology and GOCART forecasted aerosol with Thompson microphysics #2

Merged

Conversation

ChunxiZhang-NOAA
Copy link

@ChunxiZhang-NOAA ChunxiZhang-NOAA commented Sep 16, 2022

All credit for code changes and description to Anning Cheng.

MERRA2 climatological aerosols are used to calculate number concentrations of ice friendly and liquid friendly aerosols. IN and CCN can be activated by using aerosols. The indirect interactions of aerosols and clouds are expected to happen. This PR is created to replace the NCAR/ccpp-physics PR#720, which was created by Anning Cheng.

The MERRA2 coupled Thompson (EXP MRAERO) shows improvement from the control run and the forecasted NIFA and NWFA approach (LTAERO), specially decreased cloud water bias as shown in the attached poster. More comprehensive comparison located at https://www.emc.ncep.noaa.gov/gmb/acheng/mraero/.

Because the GOCART coupled Thompson scheme shares the same IN/CCN activation module as the MERRA2 coupled Thompson scheme, we expect more improvements. Some results can be found here:
gass_3_v1.pdf

AnningCheng-NOAA and others added 30 commits August 23, 2021 13:34
Update to mraerosol branch from Dom
…_20211018

Anning mraerosol updates dom 20211018
@ChunxiZhang-NOAA
Copy link
Author

@AnningCheng-NOAA @gthompsnWRF Please review this PR at your convenience.

Copy link
Collaborator

@AnningCheng-NOAA AnningCheng-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

look good to me. Approved

@AnningCheng-NOAA
Copy link
Collaborator

AnningCheng-NOAA commented Sep 26, 2022 via email

Copy link
Collaborator

@Qingfu-Liu Qingfu-Liu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Although I did not run the tests, but the code changes look good to me.

@ChunxiZhang-NOAA
Copy link
Author

@grantfirl @dustinswales Could you please review this PR again, thanks.

physics/module_mp_thompson.F90 Outdated Show resolved Hide resolved
physics/module_mp_thompson.F90 Show resolved Hide resolved
physics/module_mp_thompson.F90 Show resolved Hide resolved
physics/module_mp_thompson.F90 Show resolved Hide resolved
physics/module_mp_thompson.F90 Show resolved Hide resolved
physics/mp_thompson.F90 Show resolved Hide resolved
physics/mynnedmf_wrapper.F90 Show resolved Hide resolved
physics/mynnedmf_wrapper.F90 Show resolved Hide resolved
physics/module_mp_thompson.F90 Outdated Show resolved Hide resolved
physics/module_mp_thompson.F90 Show resolved Hide resolved
physics/mp_thompson.F90 Show resolved Hide resolved
@AnningCheng-NOAA
Copy link
Collaborator

AnningCheng-NOAA commented Sep 27, 2022 via email

@AnningCheng-NOAA
Copy link
Collaborator

AnningCheng-NOAA commented Sep 28, 2022 via email

@gthompsnWRF
Copy link
Collaborator

@AnningCheng-NOAA I am seeking a bigger description, most importantly, as I indicated at the start, please indicate what are the constituents that represent the last index of the aerfld array. In other words, which is organic carbon, sulfates, sea-salts, etc. And, if any of them are size-bin such as dust, please specify something about the range of the bins. This will greatly help others, particularly me when anyone else wants to discuss adopting the T-E scheme to another aerosol dataset. Thank you.

@AnningCheng-NOAA
Copy link
Collaborator

AnningCheng-NOAA commented Sep 30, 2022 via email

@ChunxiZhang-NOAA ChunxiZhang-NOAA merged commit 9c1943c into ufs-community:ufs/dev Sep 30, 2022
@gthompsnWRF
Copy link
Collaborator

gthompsnWRF commented Sep 30, 2022

@AnningCheng-NOAA @ChunxiZhang-NOAA Perhaps this is a problem with Github, but I did not see the new comment from late yesterday added into the code itself. I even refreshed the files changed page but it is not showing.

When I directly view the commit tag 9c1943c I do not see the update of documentation by @AnningCheng-NOAA. I would like to respectfully request that this merge commit be reverted. Then the comment can be included and then the merge should proceed. It is really imperative that others know what species are included.

@ChunxiZhang-NOAA
Copy link
Author

@AnningCheng-NOAA @ChunxiZhang-NOAA Perhaps this is a problem with Github, but I did not see the new comment from late yesterday added into the code itself. I even refreshed the files changed page but it is not showing.

@gthompsnWRF Sorry for that. The PR commit process had started when your latest comment showed up (It took more than one day). We will add the detailed description and combine with other PR.

@grantfirl
Copy link
Collaborator

@AnningCheng-NOAA @ChunxiZhang-NOAA Perhaps this is a problem with Github, but I did not see the new comment from late yesterday added into the code itself. I even refreshed the files changed page but it is not showing.

@gthompsnWRF Sorry for that. The PR commit process had started when your latest comment showed up (It took more than one day). We will add the detailed description and combine with other PR.

@ChunxiZhang-NOAA The additional documentation was added in 9009159.

@ChunxiZhang-NOAA
Copy link
Author

@grantfirl Thank you Grant!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants