Update to consider sea surface current in air-sea flux calculation #155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
satmedmfvdif.F satmedmfvdifq.F sfc_diag.f sfc_diff.f
…utation of air-sea fluxes.
…utation of air-sea fluxes.
satmedmfvdif.F satmedmfvdif.meta satmedmfvdifq.F sfc_diag.f sfc_diff.f sfc_nst.f90 sfc_ocean.F
Change the variable name for meridional ocean current from ssv to vsfco.
binli2337
requested review from
grantfirl,
Qingfu-Liu,
dustinswales and
mzhangw
as code owners
BinLiu-NOAA
changed the title
BinLiu-NOAA
reviewed
Jan 16, 2024
BinLiu-NOAA
reviewed
Jan 16, 2024
BinLiu-NOAA
reviewed
Jan 16, 2024
BinLiu-NOAA
reviewed
Jan 16, 2024
BinLiu-NOAA
reviewed
Jan 16, 2024
BinLiu-NOAA
reviewed
Jan 16, 2024
41 tasks
grantfirl
reviewed
Jan 24, 2024
grantfirl
reviewed
Jan 24, 2024
grantfirl
reviewed
Jan 24, 2024
|
This looks fine to me with the exception of a few metadata comments. I'll approve once the comments are addressed. |
control_for_air_sea_flux_computation_over_water.
Qingfu-Liu
approved these changes
Jan 25, 2024
mzhangw
reviewed
Jan 25, 2024
mzhangw
approved these changes
Jan 25, 2024
grantfirl
approved these changes
Jan 26, 2024
BinLiu-NOAA
approved these changes
Jan 26, 2024
…hafsv2_baseline_with_ssc
|
@binli2337 can you sync up branch? We also consider to combine #157 to this pr. Changes of two PRs are orthogonal. @grantfirl Can I ask your opinion? |
@jkbk2004 In my opinion, this is a fine thing to do! @binli2337 Could you please merge #157 into this branch (here and in fv3atm and ufs-weather-model PR branches too, if there are changes other than submodule pointer updates). |
|
@grantfirl testing is complete on ufs-wm PR#2104. Please feel free to merge this ccpp-physics sub-pr for us. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The ccpp-physics code will be updated to include surface ocean current in the computation of air-sea fluxes.
Issue(s) addressed
Dependencies
Co-authored-by @binli2337, @BinLiu-NOAA, @WeiguoWang-NOAA, @BijuThomas-NOAA, @hyunsookkim-NOAA, @XuLi-NOAA, @MariaAristizabal-NOAA, @JohnSteffen-NOAA