From ee0cbb08132a4cac2ee1404eb3b6863372c580dc Mon Sep 17 00:00:00 2001 From: svenadlung Date: Tue, 6 Dec 2022 15:39:58 +0100 Subject: [PATCH] fix(extension-bubble-menu): don't debounce without valid selection --- .../extension-bubble-menu/src/bubble-menu-plugin.ts | 10 +++------- 1 file changed, 3 insertions(+), 7 deletions(-) diff --git a/packages/extension-bubble-menu/src/bubble-menu-plugin.ts b/packages/extension-bubble-menu/src/bubble-menu-plugin.ts index a20e8c2cf46..42fd6953d44 100644 --- a/packages/extension-bubble-menu/src/bubble-menu-plugin.ts +++ b/packages/extension-bubble-menu/src/bubble-menu-plugin.ts @@ -168,14 +168,10 @@ export class BubbleMenuView { const { state } = view const hasValidSelection = state.selection.$from.pos !== state.selection.$to.pos - if (hasValidSelection) { - if (this.updateDelay > 0) { - debounce(this.updateHandler, this.updateDelay)(view, oldState) - } else { - this.updateHandler(view, oldState) - } + if (this.updateDelay > 0 && hasValidSelection) { + debounce(this.updateHandler, this.updateDelay)(view, oldState) } else { - this.hide() + this.updateHandler(view, oldState) } }