Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: NodePos.d.ts error TS2380 #5921

Closed
1 task
akbar-front opened this issue Dec 9, 2024 · 2 comments
Closed
1 task

[Bug]: NodePos.d.ts error TS2380 #5921

akbar-front opened this issue Dec 9, 2024 · 2 comments
Labels
Category: Open Source The issue or pull reuqest is related to the open source packages of Tiptap. Type: Bug The issue or pullrequest is related to a bug

Comments

@akbar-front
Copy link

akbar-front commented Dec 9, 2024

Affected Packages

core

Version(s)

2.2.4

Bug Description

The issue occurs when I try to build my project, I get typescript error in node_modules/@tiptap/core/dist/NodePos.d.ts:16:9
error TS2380: The return type of a 'get' accessor must be assignable to its 'set' accessor type
Type 'Fragment' is not assignable to type 'JSONContent'.
le type 'JSONContent[]'.

16 get content(): Fragment;

Browser Used

Edge

Code Example URL

No response

Expected Behavior

When running build, project running successfully with no typescript errors

Version: 2.2.4

Additional Context (Optional)

image

Dependency Updates

  • Yes, I've updated all my dependencies.
@akbar-front akbar-front added Category: Open Source The issue or pull reuqest is related to the open source packages of Tiptap. Type: Bug The issue or pullrequest is related to a bug labels Dec 9, 2024
@nperez0111
Copy link
Contributor

You should not be typechecking library code. In your tsconfig, set skipLibCheck: true

This is a type error that we can handle on our side, but due to the multiple versions of prosemirror we are compatible with, we cannot always compile in Typescript.

@akbar-front
Copy link
Author

Got it, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Category: Open Source The issue or pull reuqest is related to the open source packages of Tiptap. Type: Bug The issue or pullrequest is related to a bug
Projects
None yet
Development

No branches or pull requests

2 participants