-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug]: wrong peerDependencies resolving #5670
Comments
So because each package has peer deps, if you do not specify every package in your package.json to be at a specific version this can happen. Like for example you are not using the bubble menu, but it is a peer dep of vue so it is resolving to a later version. In Tiptap v3 we plan to drastically reduce the number of packages so that this would be much less of an issue for people |
What about
|
Ah, it specifies them as dependencies not peer deps: tiptap/packages/starter-kit/package.json Lines 31 to 52 in 6834a7f
This isn't really a problem with Tiptap, it is how NPM resolution works |
i think in this package dependencies should be without |
I agree that core & pm should be peer deps in starter-kit. But, starter-kit should not enforce exact dependencies (which is what removing I could see an argument for allowing any version within the major version like |
For example Storybook lock version in a similar package https://github.com/storybookjs/storybook/blob/next/code/addons/essentials/package.json#L91-L99 |
They are using yarn so it is not really comparable. Just fwiw, even if we change the versioning, you are still going to have this problem, you will need to update versions to get the change that is made. And like I said, we are reducing the number of packages with v3 |
Affected Packages
core, extension-heading, extension-link, extension-list-item, pm, starter-kit, vue-3
Version(s)
2.6.6
Bug Description
Installing these packages results in the message from npm "warn ERESOLVE overriding peer dependency"
Browser Used
Other
Code Example URL
No response
Expected Behavior
Expected that only one version(2.6.6) will be installed for
@tiptap/core
and@tiptap/pm
.Additional Context (Optional)
Dependency Updates
The text was updated successfully, but these errors were encountered: