Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs/installation cdn #4045

Merged
merged 5 commits into from
Jul 7, 2023
Merged

Docs/installation cdn #4045

merged 5 commits into from
Jul 7, 2023

Conversation

RicoTrevisan
Copy link
Contributor

Please describe your changes

  • Added 2 CDN examples: esm.sh, esm.run.
  • Uncommented CDN from the installation main page so that users can access it.

How did you accomplish your changes

I've built examples of each one of them in Codepen:

How have you tested your changes

With the Codepen examples.

How can we verify your changes

Just open the links to the different Codepens to make sure they work.

Remarks

I'm a rookie contributor, I'm trying to learn, but not sure if I'm doing it correctly. If something is missing or unclear, please let me know -- I'd love to learn.

Checklist

  • The changes are not breaking the editor
  • Added tests where possible
  • Followed the guidelines
  • Fixed linting issues

Related issues

[add a link to the related issues here]

Added 3 examples of CDN usage.
Uncommented CDN line
removed Skypack -- not reliable in testing with Codepen.
@netlify
Copy link

netlify bot commented May 14, 2023

Deploy Preview for tiptap-embed ready!

Name Link
🔨 Latest commit b34f3a2
🔍 Latest deploy log https://app.netlify.com/sites/tiptap-embed/deploys/6477bb6cc1b94300081c4a5f
😎 Deploy Preview https://deploy-preview-4045--tiptap-embed.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@svenadlung
Copy link
Contributor

svenadlung commented May 25, 2023

@RicoTrevisan Thank you so much for your contribution.

The ESM.RUN sandbox seems to have an error I think. It shows
caught RangeError: Adding different instances of a keyed plugin (plugin$1)

I am wondering how they handle peer dependencies like @tiptap/pm.

@RicoTrevisan
Copy link
Contributor Author

Hey @svenadlung , thanks for catching that. I've tried to get to the root-cause of that issue, but failed. Let's leave just the esm.sh implementation there. Hopefully this can be of help to someone.

Thanks for letting me contribute.

Copy link
Contributor

@ije ije left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ije
Copy link
Contributor

ije commented Jun 29, 2023

hi, i am the maintainer of esm.sh, glad to see this PR. if you have any problem with esm.sh please just tell me, i am happy to fix/improve. thanks!

@bdbch bdbch merged commit 8536508 into ueberdosis:develop Jul 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants