fix(link): fix links autolinking when not needed #3989
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please describe your changes
This PR changes the autolink behavior. Before links were always autolinked, even when the autolinked text was already a link. This is weird behavior - as a manually / already set link should always have priority over automatically linked content.
Example:
You have a link that has the textContent
mysite.com
but a link mark with a href attr tohttps://mysite.com?ref=my-referral-id
the autolink prior to this PR would still autolink tomysite.com
completely removing any manually set attributes.How did you accomplish your changes
Right before the autolink would set the link mark on words with spaces/breaks I added a check to see if the
link.from
andlink.to
already has a link mark inbetween. If so we just avoid autolinking to keep the already existing link.How have you tested your changes
How can we verify your changes
Checklist