Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Node following the end of a line should be removed and the text joined when Delete is pressed at the end of a line #3454

Open
1 of 2 tasks
bdbch opened this issue Nov 25, 2022 · 3 comments
Assignees
Labels
Info: Stale The issue or pullrequest has not been updated in a while and might be stale Type: Bug The issue or pullrequest is related to a bug

Comments

@bdbch
Copy link
Member

bdbch commented Nov 25, 2022

What’s the bug you are facing?

This comes from this comment:
#3192 (comment)

Basically when you're at the end of a paragraph for example (but also happens with any other block with text content) and you press Delete, the following node doesn't get joined correctly.

Instead of the next text node being joined with the current text, the node on the next line gets removed but nothing happens with the content.

Which browser was this experienced in? Are any special extensions installed?

Chrome, Firefox

How can we reproduce the bug on our side?

  1. Create a paragraph, write some text
  2. Create a blockquote after the paragraph
  3. Place your cursor at the end of the paragraph
  4. Press Delete

Can you provide a CodeSandbox?

No response

What did you expect to happen?

When delete is pressed, the text content from the next line should be joined with the current text node and the next node should be removed (or the wrapper of the empty text node at least - since you could be in a list / nested node that shouldn't be removeD).

Anything to add? (optional)

No response

Did you update your dependencies?

  • Yes, I’ve updated my dependencies to use the latest version of all packages.

Are you sponsoring us?

  • Yes, I’m a sponsor. 💖
@bdbch bdbch added the Type: Bug The issue or pullrequest is related to a bug label Nov 25, 2022
@bdbch bdbch self-assigned this Nov 25, 2022
@github-actions
Copy link
Contributor

This issue is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 7 days

@github-actions github-actions bot added the Info: Stale The issue or pullrequest has not been updated in a while and might be stale label Feb 24, 2023
@bdbch
Copy link
Member Author

bdbch commented Feb 24, 2023

bump

@github-actions github-actions bot removed the Info: Stale The issue or pullrequest has not been updated in a while and might be stale label Feb 25, 2023
@github-actions
Copy link
Contributor

This issue is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 7 days

@github-actions github-actions bot added the Info: Stale The issue or pullrequest has not been updated in a while and might be stale label May 27, 2023
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Jun 3, 2023
@bdbch bdbch reopened this Jun 25, 2023
@bdbch bdbch added this to Tiptap Aug 4, 2023
@github-project-automation github-project-automation bot moved this to Triage open in Tiptap Aug 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Info: Stale The issue or pullrequest has not been updated in a while and might be stale Type: Bug The issue or pullrequest is related to a bug
Projects
No open projects
Status: Triage open
Development

No branches or pull requests

1 participant