-
-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Node view selected
prop doesn't get updated when node is selected
#3040
Comments
I have also encountered it (on React), and I believe that #2819 is the same problem with this issue based on the demo. |
There is a temporary workaround: use Focus extension (https://tiptap.dev/api/extensions/focus) and some CSS selector trick to get the focus state. |
This issue is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 7 days |
Commenting because this is still an issue. |
This issue is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 7 days |
It seems to only update when the node itself is selected as a |
I added some functionality for updating the prop when the selection is around. Maybe this fixed the issue? Which version were you using / Could you try the most recent 2.1.0-rc.* version? |
@bdbch This seems only for React? I'm using Vue 3. |
same issue, i m try make custom paragraph but i cant get paragraph props.selected with vue3 |
What’s the bug you are facing?
I'm trying to use the node view
selected
prop (https://tiptap.dev/guide/node-views/vue#selected) but it doesn't get updated when the node is selected.Which browser was this experienced in? Are any special extensions installed?
Firefox 103.0 on Ubuntu 22.04.
No special extensions, just
@tiptap/starter-kit
+ a custom node view to show the issue.How can we reproduce the bug on our side?
Can you provide a CodeSandbox?
https://codesandbox.io/s/tiptap-node-view-selected-prop-issue-yneccj
What did you expect to happen?
Node view
selected
prop value should betrue
if selection is at node position (as stated in the docs).Anything to add? (optional)
This is the first time I'm using this prop so I don't know if it already worked and if it did, when it stopped working.
It's probably the same issue than #2819.
Did you update your dependencies?
Are you sponsoring us?
The text was updated successfully, but these errors were encountered: