Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Write more tests #2033

Closed
4 of 25 tasks
hanspagel opened this issue Oct 13, 2021 · 2 comments
Closed
4 of 25 tasks

Write more tests #2033

hanspagel opened this issue Oct 13, 2021 · 2 comments
Labels
Type: Feature The issue or pullrequest is a new feature

Comments

@hanspagel
Copy link
Contributor

hanspagel commented Oct 13, 2021 •
edited by philippkuehn
Loading

What problem are you facing?

There are a few examples that don’t have any tests:

What’s the solution you would like to see?

It would be great to change this. Maybe some people would like to help with that?

What alternatives did you consider?

We have a few hundred tests already, so maybe it’s fine to leave them empty. But on the other side examples break from time to time, and having more tests feels just better and should make contributing easier.

Anything to add? (optional)

  1. There is no need to reinvent the wheel. We already have a ton of tests and a lot of them can probably be copied and just slightly modified.
  2. If you’re up to contribute tests, make sure to file PRs for a single test file only. That makes looking through them and merging them way easier.

How to write tests

  1. Fork the repo, clone it to your machine.
  2. Install everything with yarn install
  3. Open the test console with yarn test:open
  4. Start writing tests in one of the above mentioned files
  5. Push your changes and create a PR 🙌

Are you sponsoring us?

  • Yes, I’m a sponsor. 💖
@hanspagel hanspagel added Type: Feature The issue or pullrequest is a new feature help wanted labels Oct 13, 2021
@donovanglover donovanglover mentioned this issue Oct 15, 2021
Merged
@donovanglover
Copy link
Contributor

Thanks for this opportunity! It's a good way to practice using cypress in a real project.

@AlexandruValeanu AlexandruValeanu mentioned this issue Oct 16, 2021
Merged
@alb alb mentioned this issue Oct 18, 2021
Merged
@hanspagel
Copy link
Contributor Author

Added this for hacktoberfest, so closing this for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Type: Feature The issue or pullrequest is a new feature
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@hanspagel @donovanglover