Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing scopeId's with VueNodeView's #1931

Closed
Olli1080 opened this issue Sep 22, 2021 · 0 comments
Closed

Missing scopeId's with VueNodeView's #1931

Olli1080 opened this issue Sep 22, 2021 · 0 comments
Labels
Type: Bug The issue or pullrequest is related to a bug

Comments

@Olli1080
Copy link

Olli1080 commented Sep 22, 2021

Description
When using tiptap with vue-3 and scoped styles, scoped styles are not displayed on rendered nodes if there is any data (e.g. ref) or event binding attached.

Steps to reproduce the bug
Steps to reproduce the behavior:

  1. Go to https://github.com/Olli1080/vue-3-ssr-reproduction/tree/tiptap-vue-3-repro
  2. Checkout the tiptap-vue-3-repro branch
  3. Run npm i
  4. Run npm start
  5. Goto localhost:3000

Expected behavior
The scopedId's should be applied to every element of the component resulting in the first image.

Screenshot, video, or GIF
Should be:
soll

Is state:
ist

Environment?

  • operating system: Windows 10
  • browser: firefox
  • mobile/desktop: desktop
  • tiptap version: 2.0.0-beta.110
  • tiptap/vue-3: 2.0.0-beta.61

Additional context
After some debugging it appears that the original scopeId is hidden after extending the original component inside VueNodeViewRenderer.ts@VueNodeView which results in it not being set by setCurrentRenderingInstance https://github.com/vuejs/vue-next/blob/master/packages/runtime-core/src/componentRenderContext.ts. The reason that the other scopeId's on non bound elements are still applied is due to precomputed values, which are precomputed inside the original component.
I haven't been able to find a fix on my own so far.

@Olli1080 Olli1080 added Type: Bug The issue or pullrequest is related to a bug v2 labels Sep 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug The issue or pullrequest is related to a bug
Projects
None yet
Development

No branches or pull requests

1 participant