Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

After upgrading @tiptap/core to v2.0.0-beta.92, toggle buttons will lose focus from selected text #1658

Closed
atulmy opened this issue Jul 29, 2021 · 3 comments
Labels
Type: Bug The issue or pullrequest is related to a bug

Comments

@atulmy
Copy link

atulmy commented Jul 29, 2021

Description
When clicking on any toggle button with text selected, the action will happen (for example bold) but the cursor will either jump to end of word/paragraph or at the start of paragraph.

I upgraded to v2.0.0-beta.92 from v2.0.0-beta.86 (issue was not present in v.86).

Expected behavior
When toggling, text selection should be preserved so that user can apply multiple actions like underline, bold etc without selecting text again and again.

@atulmy atulmy added Type: Bug The issue or pullrequest is related to a bug v2 labels Jul 29, 2021
@philippkuehn
Copy link
Contributor

Can you reproduce this somehow? I can’t see that in our examples in the docs.

@cadars
Copy link
Contributor

cadars commented Jul 29, 2021

It happens with the bubble menu example: https://www.tiptap.dev/guide/menus#bubble-menu

@atulmy
Copy link
Author

atulmy commented Jul 30, 2021

Thanks for the quick fix! Really appreciate the help :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug The issue or pullrequest is related to a bug
Projects
None yet
Development

No branches or pull requests

3 participants