Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue 629: Revise vocabulary pattern #630

Draft
wants to merge 15 commits into
base: develop
Choose a base branch
from
Draft

Issue 629: Revise vocabulary pattern #630

wants to merge 15 commits into from

Conversation

ajnelson-nist
Copy link
Contributor

@ajnelson-nist ajnelson-nist commented Aug 13, 2024 •
edited
Loading

This Pull Request will resolve all backwards-compatible requirements of #629 .

Coordination

  • Pull Request is against correct branch
  • Pull Request is in, or reverted to, Draft status before Solutions Approval vote has passed
  • CI passes in UCO feature branch against develop
  • CI passes in UCO current unstable branch (bd2b412)
  • CI passes in CASE current unstable branch tracking UCO's unstable as submodule (7c9defb)
  • Impact on SHACL validation reviewed for CASE-Corpora
  • Impact on SHACL validation remediated for CASE-Corpora
  • Impact on SHACL validation reviewed for CASE-Examples
  • Impact on SHACL validation remediated for CASE-Examples (N/A)
  • Impact on SHACL validation reviewed for casework.github.io
  • Impact on SHACL validation remediated for casework.github.io (N/A)
  • Milestone linked
  • Solutions Approval vote logged on corresponding Issue (once logged, can be taken out of Draft PR status)

@ajnelson-nist
Demonstrate revised vocabulary pattern on types:hashMethod
aea0c04 
A follow-on patch will regenerate Make-managed files.

References:
* #629

Signed-off-by: Alex Nelson <alexander.nelson@nist.gov>
@ajnelson-nist
Regenerate Make-managed files
6d385ba 
References:
* #629

Signed-off-by: Alex Nelson <alexander.nelson@nist.gov>
@ajnelson-nist ajnelson-nist added this to the UCO 1.4.0 milestone Aug 13, 2024
@ajnelson-nist ajnelson-nist linked an issue Aug 13, 2024 that may be closed by this pull request
UCO semi-open vocabularies need to become enumerations of xsd:strings #629
Open
15 tasks
@ajnelson-nist
Merge branch 'develop' into BugFix-Issue-629
ceaa62e
@ajnelson-nist
Revise vocabulary pattern for core:ObjectStatusVocab
54ea222 
A follow-on patch will regenerate Make-managed files.

References:
* #549
* #629

Signed-off-by: Alex Nelson <alexander.nelson@nist.gov>
@ajnelson-nist
Regenerate Make-managed files
12855bf 
References:
* #549
* #629

Signed-off-by: Alex Nelson <alexander.nelson@nist.gov>
@ajnelson-nist
Merge branch 'develop' into BugFix-Issue-629
5e4bd70
@ajnelson-nist
Revert addition of types:hashMethod-objects-in-shape
dc6b862 
This partially undoes commit `aea0c04`, because of the introduction of
`sh:targetObjectsOf` usage that would have a broad impact.  This will
return for review later.

A follow-on patch will regenerate Make-managed files.

References:
* #629

Signed-off-by: Alex Nelson <alexander.nelson@nist.gov>
@ajnelson-nist
Regenerate Make-managed files
7037123 
References:
* #629

Signed-off-by: Alex Nelson <alexander.nelson@nist.gov>
@ajnelson-nist
Revise test to use new vocabulary pattern
d7ea496 
References:
* #629

Signed-off-by: Alex Nelson <alexander.nelson@nist.gov>
@ajnelson-nist
Apply revised vocabulary pattern
ed274b1 
A follow-on patch will regenerate Make-managed files.

References:
* #629

Signed-off-by: Alex Nelson <alexander.nelson@nist.gov>
@ajnelson-nist
Regenerate Make-managed files
e6decb6 
References:
* #629

Signed-off-by: Alex Nelson <alexander.nelson@nist.gov>
@ajnelson-nist ajnelson-nist force-pushed the BugFix-Issue-629 branch 2 times, most recently from e6decb6 to ed274b1 Compare February 18, 2025 22:55
@ajnelson-nist ajnelson-nist mentioned this pull request Feb 21, 2025
Draft
@ajnelson-nist
Move sh:in review to named PropertyShapes
5ded259 
This patch introduces a name scheme that does not align with a previous
occurrence of this export,
`observable:regionalInternetRegistry-shape-value-not-vocabulary-member`.

This patch also does not apply the exporting pattern to
`core:objectStatus`, because in that case the vocabulary is closed.

A follow-on patch will regenerate Make-managed files.

References:
* #629

Signed-off-by: Alex Nelson <alexander.nelson@nist.gov>
@ajnelson-nist
Regenerate Make-managed files
d524b8e 
References:
* #629

Signed-off-by: Alex Nelson <alexander.nelson@nist.gov>
@ajnelson-nist
Fix logging syntax
68ffd02 
No effects were observed on Make-managed files.

References:
* https://docs.python.org/3.9/library/logging.html#logging.Logger.debug

Signed-off-by: Alex Nelson <alexander.nelson@nist.gov>
@ajnelson-nist
Expand paths to SHACL vocabulary lists
26a1b94 
No effects were observed on Make-managed files.

References:
* #629

Signed-off-by: Alex Nelson <alexander.nelson@nist.gov>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Change Proposal
Projects
None yet
Milestone
UCO 1.4.0
Development

Successfully merging this pull request may close these issues.

UCO semi-open vocabularies need to become enumerations of xsd:strings
1 participant
@ajnelson-nist