-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(Chore): Migrate to poetry #141
Conversation
resumable
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good assuming we can get this to pass jenkins.
requirements.txt
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a reason we're still tracking requirements.txt after migrating to poetry?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe that is still needed for the Google dataflow job
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah its a different requirements file thats supposed to provide the dependencies for the google dataflow job. The poetry toml installs the dependencies on the kubernetes job and the kubernetes job initiates a google job which uses the requriements.txt
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was able to fix the snyk issue and we were able to get it tested on a dev environment. Everything is looking good!
Description about what this pull request does.
Please make sure to follow the DEV guidelines before asking for review.
New Features
Breaking Changes
Bug Fixes
Improvements
Dependency updates
black
onpre-commit
python3.9-buster-2.0.0
Deployment changes
NOTES: changed
scripts
folder todcfdataservice
. I did not pickdcf-dataservice
overdcfdataservice
because poetry's toml file does not like special characters like-
or_