Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

uses-material-design #607

Closed
jpnurmi opened this issue Feb 9, 2023 · 3 comments · Fixed by #608
Closed

uses-material-design #607

jpnurmi opened this issue Feb 9, 2023 · 3 comments · Fixed by #608

Comments

@jpnurmi
Copy link
Member

jpnurmi commented Feb 9, 2023

Why does yaru_widgets set uses-material-design: true in its pubspec? Is it not supposed to be set by applications?

I keep getting this annoying warning whenever I run tests for the ubuntu-desktop-installer/packages/ubuntu_wizard package:

ubuntu-desktop-installer/packages/ubuntu_wizard (main)$ flutter test
package:yaru_widgets has `uses-material-design: true` set but the primary pubspec contains `uses-material-design: false`. If the application needs material icons, then
`uses-material-design`  must be set to true.
00:04 +81: All tests passed!
@jpnurmi
Copy link
Member Author

jpnurmi commented Feb 9, 2023 •
edited
Loading

Could it be a leftover because the package was originally generated using the app template?

@Feichtmeier
Copy link
Member

I have seriously no idea why this is set =) maybe in the migration phase this was needed?

@jpnurmi
Copy link
Member Author

jpnurmi commented Feb 9, 2023

Ok, let's kill it with joy and then we'll wait and see if anything breaks :)

@jpnurmi jpnurmi mentioned this issue Feb 9, 2023
Merged
jpnurmi added a commit that referenced this issue Feb 9, 2023
@jpnurmi
pubspec.yaml: clean up uses-material-design: true (#608)
8f71177 
Probably a leftover from the app template. The package was generated
without passing "--template package" so Flutter generated a pubspec for
an app.

Fixes: #607
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

pubspec.yaml: clean up uses-material-design: true
2 participants
@jpnurmi @Feichtmeier