-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add listenbrainz scrobbling support #1047
Conversation
As far as I can tell, I followed their icon design guidelines. |
@Feichtmeier if you want you can replace the PNG with a SVG from the same link for the icon. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you the code looks very good! GJ!
I just think we might need to call init() again after you activated it or did I miss this?
Like maybe from the app model initListenbrainz() => _exposeService.initListenBrainz()... which calls _listenBrainzService().init() after you entered the api key and after you pressed the button together with the setting you set?
The icon is fine, looks very good!
Umm I don't think we need to, the init method simply reads the key from shared prefs and sets up the listenbrainz model. What edge case do you have in mind where this needs to be called twice? |
..registerLazySingleton(
() => ListenBrainzService(
settingsService: di<SettingsService>(),
)..init(),
) this lazy registration registeres this callback that is called when |
Oh okay I did not know that quirk of get_it! I'll make the changes. |
I fixed it and as a bonus the app will also update the now playing on listenbrainz. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you very much! GJ!
Added listenbrainz scrobbling. (#1029)
ListenBrainz icon was taken from here which is licensed under creative commons.