Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make unlocking more flexible #1479

Closed
NeoTheThird opened this issue Oct 27, 2020 · 9 comments · Fixed by #1576
Closed

Make unlocking more flexible #1479

NeoTheThird opened this issue Oct 27, 2020 · 9 comments · Fixed by #1576
Assignees
Labels
enhancement a new feature or an improvement of existing functionality

Comments

@NeoTheThird
Copy link
Member

NeoTheThird commented Oct 27, 2020

Some newer devices don't use fastboot oem unlock, so we need a new config option that's fed into the oem lock error handling. Fun! Other devices require a key such as this: fastboot.exe -i 0x0fce oem unlock 0xKEY.

@NeoTheThird NeoTheThird added the enhancement a new feature or an improvement of existing functionality label Oct 27, 2020
@NeoTheThird NeoTheThird self-assigned this Oct 27, 2020
@NeoTheThird NeoTheThird changed the title Support fastboot flashing unlock Make unlocking more flexible Oct 28, 2020
@NeoTheThird NeoTheThird pinned this issue Oct 30, 2020
NeoTheThird added a commit that referenced this issue Nov 15, 2020
NeoTheThird added a commit that referenced this issue Nov 15, 2020
@robiwan1
Copy link

...what about adding unlock code to the "fastboot oem unlock..." command????

@NeoTheThird
Copy link
Member Author

that's exactly what's the idea here.

@robiwan1
Copy link

fantastic, i think the fastest and easiest way to implement is, to add a var in config json like this:
"unlock_code": [""],
If unlock_code is empty (default in all config files) - just run "fastboot oem unlock" as before. If there is an unlock_code, run "fastboot oem unlock 0x<unlock_code>"

@robiwan1
Copy link

How can i set my unlock code? I did not find any config or input file to pass the code to the fastboot command. I used version 0.8.0...

@NeoTheThird
Copy link
Member Author

@robiwan1 Yes, this is not implemented in the installer yet. Follow the guide in the link that the installer shows you.

@robiwan1
Copy link

Sorry for making multible comments at the same matter - i was not sure which post would be the best for asking. I saw this "New unlock features" #53 and thought, this means that it is implemented yet. Specially because i saw code to "accept oem unlock code".

@NeoTheThird
Copy link
Member Author

@robiwan1 sorry for the confusion. the pull request you commented on implemented prerequisites to fix this in our library that handles fastboot. The new library calls will now need to be implemented in the installer. This requires changes to the config specification, as well as changes to the installer's UI and backend code. Working as fast as we can, but it'll be at least another week before it'll be considered stable.

@robiwan1
Copy link

@NeoTheThird Thanks for the explanation. I Don't want you being in such a hurry! ;-) I unlocked now from cli with the fastbook-command from appimage (/tmp/.mount....) and the installer finished successfully. BUT now my Sony xpedia x perf. hangs in a boot loop. I have tried system images stable, devel and edge without success...

@robiwan1
Copy link

i now stuck exacly in the closed issue #1503...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement a new feature or an improvement of existing functionality
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants