Add Pixel 3a (sargo) #38
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
As all the necessary rootfs changes are in now I consider this ready for review! This requires a UBports installer with fastboot:set_active functionality, so make sure to only merge it when such a version is released. |
NeoTheThird
reviewed
Oct 27, 2020
|
|
fredldotme
force-pushed
the
sargo
branch
2 times, most recently
from
ef86e8a
to
f5779d4
Compare
Sargo exposes weird behavior when flashing onto the 'a' slot. After installation it automatically reboots into the recovery again, causing the boot counter to decrement with every reboot due to the phone not rebooting into a working rootfs anymore. So, the test device wins now, set the active slot to 'b' as that's the only slot it successfully boots from.
NeoTheThird
approved these changes
Nov 8, 2020
There was a problem hiding this comment.
LGTM! With UBports Installer 0.6.0-beta released, i'm ok if you are @fredldotme. Good job!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes new device support for the Google Pixel 3a.
Full device support is dependent on changes in the rootfs, so keep this PR as a draft until those issues have been solved.