feat(ci): honor IMAGE_REGISTRY in Containerfile
#607
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
size:S
castrojo
approved these changes
Jul 27, 2024
bsherman
approved these changes
Jul 29, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
|
@m0gg please don't force push in PRs, especially after reviews Doing so loses context for comments previously made and makes it difficult or impossible to see what changed. I know this isn't a complex example, but the point still stands. |
bsherman
approved these changes
Jul 31, 2024
|
Alright, no problem. I'm just used to rebase before a (ff) merge. |
bsherman
approved these changes
Jul 31, 2024
Yep, I understand. It's something I never cared about until I started reviewing PRs more often. Thank you. |
castrojo
approved these changes
Jul 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a small one.
A fix for a statically referenced repo in the workflow and actually honoring the
IMAGE_REGISTRYin the Containerfile.