Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(deck): add tdpfix for cards that has 15W TDP on boot due to writable sysfs on boot #892

Merged
merged 2 commits into from
Mar 18, 2024

Conversation

HikariKnight
Copy link
Member

@HikariKnight HikariKnight commented Mar 18, 2024

We do not know what causes a super small subset of GPUs to boot with sysfs writable on the deck images, but this will at least set the permissions back to 644 and reset the TDP at boot if it was messed with by gamescope-session and steam.

DNM before d3Xt3r tests and verifies that this works in testing as they have a system affected by this issue

@HikariKnight HikariKnight self-assigned this Mar 18, 2024
@HikariKnight HikariKnight changed the title feat(deck): add tdpfix for cards that has their sysfs writable on boot feat(deck): add tdpfix for cards that has their sysfs writable on boot and stuck at 15W TDP Mar 18, 2024
@HikariKnight HikariKnight changed the title feat(deck): add tdpfix for cards that has their sysfs writable on boot and stuck at 15W TDP feat(deck): add tdpfix for cards that has 15W TDP on boot due to writable sysfs on boot Mar 18, 2024
@HikariKnight HikariKnight marked this pull request as ready for review March 18, 2024 10:17
@HikariKnight HikariKnight requested a review from EyeCantCU as a code owner March 18, 2024 10:17
@HikariKnight
Copy link
Member Author

d3Xt3r confirmed the tdpfix works, currently we have only had this happen with amd cards when the amdgpu module has loaded.

@HikariKnight HikariKnight enabled auto-merge March 18, 2024 10:18
@KyleGospo KyleGospo merged commit 0bbd9a5 into main Mar 18, 2024
1 check passed
@Decker-01
Copy link

Decker-01 commented Apr 6, 2024

How can i check, if i have this fix already installed on my Device? This fix seems to be in Release 2.5.0 but i‘m not sure where i can see the release of bazzite that is installed.

@HikariKnight
Copy link
Member Author

How can i check, if i have this fix already installed on my Device? This fix seems to be in Release 2.5.0 but i‘m not sure where i can see the release of bazzite that is installed.

if rpm-ostree status say you are on bazzite:latest and version ends with a recent date then you are on 2.5.0
the bazzite "version" on github is irrelevant as soon as you have bazzite installed on the system.

you can also just check if you have /usr/libexec/bazzite-tdpfix.
you can check if it was triggered with journalctl -xe -t bazzite-tdpfix, the conditions to make it run are pretty specific (but we can adjust them)

currently the condition is that the current TDP has to be 15W (as this is the bug), and the default TDP for the card has to be higher than 45W (this is to avoid "fixing" this for any handhelds or laptops)

@Decker-01
Copy link

The file /usr/libexec/bazziite-tdpfix exiists, it is not triggered.

When i first insalled bazzite, my Graphics card was not installed. I ran the installation and configuration with the onboard gpu. The Onboard Gpu is still active. i will try it again tomorrow after the onboard gpu ist disabled. As far as i know, i can disabled it in the bios.
Maybe the fix is not triggered, because the onboard GPU (a Raphael-Chip) needs a tdp of <45 watts.

@HikariKnight
Copy link
Member Author

The file /usr/libexec/bazziite-tdpfix exiists, it is not triggered.

When i first insalled bazzite, my Graphics card was not installed. I ran the installation and configuration with the onboard gpu. The Onboard Gpu is still active. i will try it again tomorrow after the onboard gpu ist disabled. As far as i know, i can disabled it in the bios. Maybe the fix is not triggered, because the onboard GPU (a Raphael-Chip) needs a tdp of <45 watts.

open an issue and we can work on it from there, instead of a closed PR, i already have some potential ideas to try

@Decker-01
Copy link

Okay, thanks.
See Issue #965

@HikariKnight HikariKnight deleted the tdpcorrection branch April 20, 2024 23:08
@misteryolo
Copy link

How can i check, if i have this fix already installed on my Device? This fix seems to be in Release 2.5.0 but i‘m not sure where i can see the release of bazzite that is installed.

if rpm-ostree status say you are on bazzite:latest and version ends with a recent date then you are on 2.5.0 the bazzite "version" on github is irrelevant as soon as you have bazzite installed on the system.

you can also just check if you have /usr/libexec/bazzite-tdpfix. you can check if it was triggered with journalctl -xe -t bazzite-tdpfix, the conditions to make it run are pretty specific (but we can adjust them)

currently the condition is that the current TDP has to be 15W (as this is the bug), and the default TDP for the card has to be higher than 45W (this is to avoid "fixing" this for any handhelds or laptops)

Hi i hope youre doing well, im running an rx 6600 with bazzite deck image on a modded steam deck, my tdp is locked at 15 watts, i check and the bazzite-tdpfix is being run but its giving out his error:
( stat: cannot statx '/sys/class/hwmon/hwmon3/power1_cap'$'\n''/sys/class/hwmon/hwmon4/power1_cap': No such file or directory )
even tho i checked and the file does exists in that directory, seems puzzling to me,

when i run this it gives me :
find /sys/class/hwmon/*/ -name "power1_cap"
/sys/class/hwmon/hwmon3/power1_cap
/sys/class/hwmon/hwmon4/power1_cap

idk if you need this but : rpm-ostree status
State: idle
Deployments:
● ostree-image-signed:docker://ghcr.io/ublue-os/bazzite-deck:stable
Digest: sha256:b5b9747ef6b7608fcca8b9813d95509b2ae9235a1ba37a1fb49ef175c46e86bb
Version: 40.20240621.0 (2024-06-21T05:13:33Z)

ostree-image-signed:docker://ghcr.io/ublue-os/bazzite-deck:stable
Digest: sha256:b5b9747ef6b7608fcca8b9813d95509b2ae9235a1ba37a1fb49ef175c46e86bb
Version: 40.20240621.0 (2024-06-21T05:13:33Z)

@HikariKnight
Copy link
Member Author

How can i check, if i have this fix already installed on my Device? This fix seems to be in Release 2.5.0 but i‘m not sure where i can see the release of bazzite that is installed.

if rpm-ostree status say you are on bazzite:latest and version ends with a recent date then you are on 2.5.0 the bazzite "version" on github is irrelevant as soon as you have bazzite installed on the system.
you can also just check if you have /usr/libexec/bazzite-tdpfix. you can check if it was triggered with journalctl -xe -t bazzite-tdpfix, the conditions to make it run are pretty specific (but we can adjust them)
currently the condition is that the current TDP has to be 15W (as this is the bug), and the default TDP for the card has to be higher than 45W (this is to avoid "fixing" this for any handhelds or laptops)

Hi i hope youre doing well, im running an rx 6600 with bazzite deck image on a modded steam deck, my tdp is locked at 15 watts, i check and the bazzite-tdpfix is being run but its giving out his error: ( stat: cannot statx '/sys/class/hwmon/hwmon3/power1_cap'$'\n''/sys/class/hwmon/hwmon4/power1_cap': No such file or directory ) even tho i checked and the file does exists in that directory, seems puzzling to me,

when i run this it gives me : find /sys/class/hwmon/*/ -name "power1_cap" /sys/class/hwmon/hwmon3/power1_cap /sys/class/hwmon/hwmon4/power1_cap

idk if you need this but : rpm-ostree status State: idle Deployments: ● ostree-image-signed:docker://ghcr.io/ublue-os/bazzite-deck:stable Digest: sha256:b5b9747ef6b7608fcca8b9813d95509b2ae9235a1ba37a1fb49ef175c46e86bb Version: 40.20240621.0 (2024-06-21T05:13:33Z)

ostree-image-signed:docker://ghcr.io/ublue-os/bazzite-deck:stable Digest: sha256:b5b9747ef6b7608fcca8b9813d95509b2ae9235a1ba37a1fb49ef175c46e86bb Version: 40.20240621.0 (2024-06-21T05:13:33Z)

hey, this PR should cover this scenario now :)
#1279

@misteryolo
Copy link

misteryolo commented Jun 25, 2024

How can i check, if i have this fix already installed on my Device? This fix seems to be in Release 2.5.0 but i‘m not sure where i can see the release of bazzite that is installed.

if rpm-ostree status say you are on bazzite:latest and version ends with a recent date then you are on 2.5.0 the bazzite "version" on github is irrelevant as soon as you have bazzite installed on the system.
you can also just check if you have /usr/libexec/bazzite-tdpfix. you can check if it was triggered with journalctl -xe -t bazzite-tdpfix, the conditions to make it run are pretty specific (but we can adjust them)
currently the condition is that the current TDP has to be 15W (as this is the bug), and the default TDP for the card has to be higher than 45W (this is to avoid "fixing" this for any handhelds or laptops)

Hi i hope youre doing well, im running an rx 6600 with bazzite deck image on a modded steam deck, my tdp is locked at 15 watts, i check and the bazzite-tdpfix is being run but its giving out his error: ( stat: cannot statx '/sys/class/hwmon/hwmon3/power1_cap'$'\n''/sys/class/hwmon/hwmon4/power1_cap': No such file or directory ) even tho i checked and the file does exists in that directory, seems puzzling to me,
when i run this it gives me : find /sys/class/hwmon/*/ -name "power1_cap" /sys/class/hwmon/hwmon3/power1_cap /sys/class/hwmon/hwmon4/power1_cap
idk if you need this but : rpm-ostree status State: idle Deployments: ● ostree-image-signed:docker://ghcr.io/ublue-os/bazzite-deck:stable Digest: sha256:b5b9747ef6b7608fcca8b9813d95509b2ae9235a1ba37a1fb49ef175c46e86bb Version: 40.20240621.0 (2024-06-21T05:13:33Z)
ostree-image-signed:docker://ghcr.io/ublue-os/bazzite-deck:stable Digest: sha256:b5b9747ef6b7608fcca8b9813d95509b2ae9235a1ba37a1fb49ef175c46e86bb Version: 40.20240621.0 (2024-06-21T05:13:33Z)

hey, this PR should cover this scenario now :) #1279

You son of Gun that was real quick !! Thank you, i'm so excited to try this out, it really is a happy day :)

edit: does this fix also apply to bazzite deck?

@HikariKnight
Copy link
Member Author

How can i check, if i have this fix already installed on my Device? This fix seems to be in Release 2.5.0 but i‘m not sure where i can see the release of bazzite that is installed.

if rpm-ostree status say you are on bazzite:latest and version ends with a recent date then you are on 2.5.0 the bazzite "version" on github is irrelevant as soon as you have bazzite installed on the system.
you can also just check if you have /usr/libexec/bazzite-tdpfix. you can check if it was triggered with journalctl -xe -t bazzite-tdpfix, the conditions to make it run are pretty specific (but we can adjust them)
currently the condition is that the current TDP has to be 15W (as this is the bug), and the default TDP for the card has to be higher than 45W (this is to avoid "fixing" this for any handhelds or laptops)

Hi i hope youre doing well, im running an rx 6600 with bazzite deck image on a modded steam deck, my tdp is locked at 15 watts, i check and the bazzite-tdpfix is being run but its giving out his error: ( stat: cannot statx '/sys/class/hwmon/hwmon3/power1_cap'$'\n''/sys/class/hwmon/hwmon4/power1_cap': No such file or directory ) even tho i checked and the file does exists in that directory, seems puzzling to me,
when i run this it gives me : find /sys/class/hwmon/*/ -name "power1_cap" /sys/class/hwmon/hwmon3/power1_cap /sys/class/hwmon/hwmon4/power1_cap
idk if you need this but : rpm-ostree status State: idle Deployments: ● ostree-image-signed:docker://ghcr.io/ublue-os/bazzite-deck:stable Digest: sha256:b5b9747ef6b7608fcca8b9813d95509b2ae9235a1ba37a1fb49ef175c46e86bb Version: 40.20240621.0 (2024-06-21T05:13:33Z)
ostree-image-signed:docker://ghcr.io/ublue-os/bazzite-deck:stable Digest: sha256:b5b9747ef6b7608fcca8b9813d95509b2ae9235a1ba37a1fb49ef175c46e86bb Version: 40.20240621.0 (2024-06-21T05:13:33Z)

hey, this PR should cover this scenario now :) #1279

You son of Gun that was real quick !! Thank you, i'm so excited to try this out, it really is a happy day :)

edit: does this fix also apply to bazzite deck?

the tdpfix script is only in the deck image (and other handheld images based on deck) as it fixes a problem that only happened on the deck image.
if the fix is needed on bazzite desktop i can easily move it there (its just that all the reports we have gotten has been from deck images)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants