Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Add DMIs for AYANEO AIR 1S, OXP2/Pro and ONEXFLY #1216

Merged
merged 4 commits into from
Jun 9, 2024
Merged

fix: Add DMIs for AYANEO AIR 1S, OXP2/Pro and ONEXFLY #1216

merged 4 commits into from
Jun 9, 2024

Conversation

WhippuSIF
Copy link
Contributor

@WhippuSIF WhippuSIF commented Jun 9, 2024 •
edited
Loading

Fixes:

  • Add AYANEO AIR 1S, ONEXPLAYER 2 (6800U), ONEXPLAYER 2 Pro (7840U), ONEXPLAYER 2 Pro "Get In the PC Handheld Shinji" Edition (EVA-01 variant), and ONEXFLY (alongside its "Get In the PC Handheld Shinji" EVA-01 variant) DMIs for their appropriate waydroid-launcher screen resolutions in addition to fixing the resolution for the AYANEO AIR Plus, due to it having a 1080p screen instead of 1200p.
  • Add said DMIs to simpledeckytdp-supported-hardware as well, thus enabling TDP control as well as iomem on the devices
  • Add only the AYANEO AIR 1S DMIs to hhd-supported-hardware as hhd only supports them (the only OXP device that hhd supports is the OXP Mini Pro).

The OXP 2 and its 7840U counterpart have the same screen resolution as the Legion Go, whereas the ONEXFLY has the same resolution as the ROG Ally.

Additional comments:

『愛してるよ！ 愛だけに！』

992097669m

(you can ignore these.)

WhippuSIF added 4 commits June 8, 2024 17:14
@WhippuSIF
fix(waydroid): Add correct waydroid resolution for AYANEO AIR Plus, a…
95aeef5 
…nd add DMIs for AYANEO AIR 1S, OXP2/Pro, and OXP F1 (ONEXFLY)

- Correct Waydroid screen resolution for AYANEO AIR Plus as it has a 1080p resolution rather that 1200p.

- Add AYANEO AIR 1S, ONEXPLAYER 2/Pro, and ONEXPLAYER F1 (ONEXFLY) DMIs for their appropriate screen resolutions.
@WhippuSIF
fix(waydroid): Correct OXP2 Pro DMI
b5423a1 
The "ARP23" at the end is supposed to be an "ARP23P."
@WhippuSIF
fix(hhd): Add DMIs for AYANEO AIR 1S (AMD R愛zen 7840U) to hhd-support…
9057eb3 
…ed-hardware

Adding AYANEO AIR 1S (AMD 7840U) DMIs for both the regular and limited editions as hhd already supports them.
@WhippuSIF
fix(simpledeckytdp): Add DMIs for AYANEO AIR 1S, OXP2/Pro, and OXP F…
3f481b9 
…1 (ONEXFLY) (all powered by AMD R愛zen 7840U)

Adding AYANEO AIR 1S, OXP2/Pro, and ONEXFLY as they already support RyzenAdj (and by extension SimpleDeckyTDP itself).

『愛してるよ！ 愛だけに！』
@WhippuSIF WhippuSIF requested a review from EyeCantCU as a code owner June 9, 2024 00:19
@KyleGospo KyleGospo enabled auto-merge June 9, 2024 01:03
@KyleGospo
Copy link
Member

Thanks!

HikariKnight
HikariKnight approved these changes Jun 9, 2024
View reviewed changes
Copy link
Member

@HikariKnight HikariKnight left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@KyleGospo KyleGospo merged commit 2a8fc70 into ublue-os:main Jun 9, 2024
2 checks passed
@github-actions github-actions bot mentioned this pull request Jun 9, 2024
Merged
@WhippuSIF WhippuSIF deleted the aya-and-oxp-dmis branch July 31, 2024 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HikariKnight HikariKnight HikariKnight approved these changes

@KyleGospo KyleGospo KyleGospo approved these changes

@EyeCantCU EyeCantCU Awaiting requested review from EyeCantCU

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@WhippuSIF @KyleGospo @HikariKnight