Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NGitLab.Mocks should throw same exceptions as NGitLab #841

Open
louis-z opened this issue Feb 3, 2025 · 0 comments
Open

NGitLab.Mocks should throw same exceptions as NGitLab #841

louis-z opened this issue Feb 3, 2025 · 0 comments

Comments

@louis-z
Copy link
Member

louis-z commented Feb 3, 2025 •
edited
Loading

The mocks are meant to fake NGitLab as faithfully as possible. As such, they should throw the same exceptions as their true NGitLab counterparts.
@louis-z louis-z changed the title Mock should not let GitLabNotFoundException bubble up to public API Mocks should not let GitLabNotFoundException bubble up to public API Feb 3, 2025
@louis-z louis-z mentioned this issue Feb 4, 2025
Merged
@louis-z louis-z changed the title Mocks should not let GitLabNotFoundException bubble up to public API NGitLab.Mocks should throw same exceptions as NGitLab Feb 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@louis-z