Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatic Workflow Deploy #55

Open
0x4007 opened this issue Oct 12, 2024 · 8 comments
Open

Automatic Workflow Deploy #55

0x4007 opened this issue Oct 12, 2024 · 8 comments

Comments

@0x4007
Copy link
Member

0x4007 commented Oct 12, 2024

If no changes were made to any of the .github/workflows/*.yml files then we should automatically run the workflows.
This is relevant for QA (build tests, continuous deploys etc.)

@0x4007
Copy link
Member Author

0x4007 commented Oct 12, 2024

@gentlementlegen how long does it take to make plugins? I assume the core logic of this is only a few lines.

@gentlementlegen
Copy link
Member

With the SDK it's two lines! However I am not sure to understand your spec.

@0x4007
Copy link
Member Author

0x4007 commented Oct 13, 2024

The problem is that for many external contributors, a collaborator must manually trigger their workflow runs because that's the default behavior of repositories on GitHub.

The thing is, we rely on our CI for QA so it just slows things down if we have to manually run the workflows every time to build/test/deploy etc

@gentlementlegen
Copy link
Member

The reason behind it is because it is potentially running malicious code. I think this behavior can be changed in GitHub settings.

@gentlementlegen
Copy link
Member

@0x4007
Copy link
Member Author

0x4007 commented Oct 13, 2024

Yes I am aware it can be manually changed for every repo but isn't that annoying to keep track of given that we make a new repo every 1-2 weeks?

@gentlementlegen
Copy link
Member

You can change this org wise so all subsequent repos will have that same rule defined: https://github.com/organizations/ubiquity-os/settings/actions. Sadly doesn't apply for previously created repos, but a script could be done about that. I think that should solve the problem?

@0x4007
Copy link
Member Author

0x4007 commented Oct 14, 2024

It might be enough I'm not sure yet

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants