chore: tests for special characters #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ers-escaping # Conflicts: # tests/__mocks__/results/github-comment-results.json # tests/__mocks__/results/output.html # tests/__mocks__/results/permit-generation-results.json
|
Added tests to make sure the serialization for complex comments works and we don't get regressions, since before it sometimes resulted in a broken UI due to HTML being interpreted when it was just the content of the comment. See this file for reference of what is tested, and this issue for run results. |
molecula451
approved these changes
May 15, 2024
gentlementlegen
merged commit 142ad6d
into
ubiquity-os-marketplace:development
2 of 3 checks passed
|
@molecula451 Why did you merge it with failing tests? |
I approved the PR here. I did not merged, gentleman merged, in any case, i think gentleman is aware of the failing tests run
|
|
@rndquu @molecula451 yes checking in the next PR since it contains more tests so was easier to fix all of them at the same time, will update all of them at once |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #18