Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

This repository is currently inactive but we're looking for maintainers #1303

Open
chrisirhc opened this issue Jan 10, 2020 · 26 comments
Open

Comments

@chrisirhc
Copy link
Contributor

chrisirhc commented Jan 10, 2020

We have decided to deprecate this library as we don't have an active maintainer.
If you'd like to take take ownership, please feel free to fork or discuss over here.

( #1248 (comment) )

@thisis-Shitanshu
Copy link

Hi @chrisirhc and @gergelyke react-viz have been an amazing library for a lot of my projects. It's sad that there's no active maintainer for such an awesome library, but rather than seeing this library being deprecated I like ownership of this project.
I firmly believe this library still has a lot of potentials for being one of the best charting libraries for all applications, mobile, and web, and desktops build with react.
Please do let me know how can I take this awesome project further!

@dev-chr
Copy link

dev-chr commented Jan 13, 2020

This really is too bad. This library has some weakness like any library. Like @thisis-Shitanshu comment, this library has incredible potential. I am wondering now why Uber wasn't investing in this library... is there something better they found?

@mcnuttandrew
Copy link
Contributor

There's an increasing trend in visualization libraries to shift away from imperative visualization declaration (e.g. put this circle here) to declarative declarations (gimmie an x/y plot with circles). While react-vis has always been a little towards the latter it doesn't feature the rich grammar of graphics style declarations that libraries like ggplot or vega-lite/altair feature. It's hard to see it go, but it's also very much a visualization library of a particular era (specifically the react-ify-everything-stylings of 2015-6). I definitely still find myself using react-vis a reasonable amount, but more and more I also find myself using vega-embed/react-vega and the like.

@chrisirhc
Copy link
Contributor Author

chrisirhc commented Jan 15, 2020

@thisis-Shitanshu you can help by playing a maintainer role and reviewing the PRs.
Our repository has always been open for help on the maintainer role, but nobody has stepped in to play this role despite its popularity. (@mcnuttandrew has been playing this role for a while but he no longer has the bandwidth to do so. Thanks @mcnuttandrew !)

I am wondering now why Uber wasn't investing in this library... is there something better they found?

We simply don't have the resources to do so. Nobody in the company has stepped up to take ownership as a maintainer.

@thisis-Shitanshu
Copy link

@chrisirhc I have always admired @mcnuttandrew 's work, his contributions have been a huge inspiration for me. I understand it takes a lot of time and effort to be a maintainer for such a huge project but if nobody is stepping in to maintain this awesome project, rather than see it being depreciated I would love to volunteer and take ownership of this project as a maintainer. I will contribute my time in reviewing PRs and add features to this library so it always stands as one of the best charting libraries.

@chrisirhc
Copy link
Contributor Author

@thisis-Shitanshu I've sent you an invite for push rights so you have permissions to move ahead to take actions as a maintainer.
Happy to chat with you if you'd like to chat about next steps. I've dropped an email in your inbox.

@thisis-Shitanshu
Copy link

@chrisirhc Thank you so much for the invite!
This is a huge opportunity for me, to be part of such an awesome project.

Whenever convenient for you, I would absolutely love to chat about the next steps.
I will be needing all the help I can get!

@krushanu
Copy link

This is one of my favourite visualization libs. Could you please also add me as a collaborator/maintainer. So that I can also share or push my code and features that I have used in my project which is built on top of React-Vis.
Please update if you have found anything new as a replacement of this Lib?
Requesting again to add as a collaborator.

@zachguo
Copy link
Contributor

zachguo commented Feb 2, 2020

There's an increasing trend in visualization libraries to shift away from imperative visualization declaration (e.g. put this circle here) to declarative declarations (gimmie an x/y plot with circles). While react-vis has always been a little towards the latter it doesn't feature the rich grammar of graphics style declarations that libraries like ggplot or vega-lite/altair feature.

That's actually why I love react-vis. The APIs are lower level than other charting libraries, and are closer to how one creates a chart via raw svg elements, less magic involved. I feel the intended users are web developers instead of data scientists with a background in R. I really hope react-vis would stay 'low-level', focus on composability and don't go the declarative route.

@chrisirhc
Copy link
Contributor Author

@krushanu me and @thisis-Shitanshu are chatting.
Please reach out to me via email and we can chat about next steps.

@shantp
Copy link

shantp commented Mar 22, 2020

I really enjoyed using this library on a recent project before reading about the deprecation. Has there been progress on the new maintainers ?

@chrisirhc
Copy link
Contributor Author

Unfortunately, not much progress to report on finding maintainers.
One main sticking point for deprecating this library is that we don't have a sound and modern strategy for styling in today's React ecosystem. I've created #1310 for this. If we can get help/contributions in that, we might be able to continue maintaining this library.

@dpordomingo
Copy link

dpordomingo commented Apr 8, 2020

Hi @chrisirhc, how is the migration to Styletrong helping to find maintainers? Is Uber making any effort in that direction? Or is that assumption just a guess from your own?
I'm asking this just to understand how much can I expect, and how much can I invest in react-vis

@chrisirhc
Copy link
Contributor Author

chrisirhc commented Apr 8, 2020

Uber has no resources to maintain this library and we've been looking for maintainers for a while now.
Uber's internal ecosystem has moved onto Styletron. As such, there's an incompatibility with using this library internally. So internal users at Uber will eventually need to move off to another charting library to style.

At this point, I don't think you can expect anything. This is open source software and we've already given strong indication that there is no support. If no one is willing to give and contribute into the project in the way it needs, then there simply is nothing you can expect.

Update: I might be completely wrong and people want a CSS styled charting library. I only know it's not the case at Uber. Either way, we welcome maintainers or forks.

@dpordomingo
Copy link

dpordomingo commented Apr 14, 2020

My question is related on how migrating to Styletron can help to find maintainers. What charting library is Uber using now if no longer using react-vis?
If react-vis would be migrated into Styletron, would Uber keep using it? And would Uber help with the maintenance in that case?
Or is this library already discarded by Uber, no matter it uses Styletron or plain CSS?

@chrisirhc
Copy link
Contributor Author

chrisirhc commented May 17, 2020

Thanks for your questions, @dpordomingo.

My question is related on how migrating to Styletron can help to find maintainers. What charting library is Uber using now if no longer using react-vis?

Internally, there's been use of echarts, Nivo, Highcharts, and still some level of usage of react-vis. There hasn't been a standard charting library used.

If react-vis would be migrated into Styletron, would Uber keep using it? And would Uber help with the maintenance in that case?

Internally, the answer is yes as we can get help from the team that maintains BaseWeb, Styletron, and FusionJS. react-vis is uses scss which is no longer a best practice nor is it tightly compatible with these new libraries/frameworks which are widely used at Uber.

Or is this library already discarded by Uber, no matter it uses Styletron or plain CSS?
It looks like there's continued interest in this library. I would like to understand from the community whether what attracts users to this library.

I'm also curious to learn if the community would still like this library once it's modernized and using styletron. Perhaps the only way to find out is to take a stab and converting some charts and making a new release.

@chrisirhc
Copy link
Contributor Author

chrisirhc commented May 18, 2020

I've put together a RFC proposal for a strategy to move onto Styletron on chrisirhc#1

It's still in iteration but please comment on it if you have any thoughts. Potentially, we can collaborate to finish this on a branch of react-vis and revive the project.

@reitlepax
Copy link
Contributor

reitlepax commented May 18, 2020

@chrisirhc I looked at your proposal and I like the idea!
I am willing to contribute and convert some charts to Styletron

@chrisirhc chrisirhc changed the title This repository is now deprecated This repository is currently inactive but we're looking for maintainers May 18, 2020
@chrisirhc
Copy link
Contributor Author

Thanks to @Xiot and @a-peltier putting in a big push this week, we've gotten some contributions going to get things started again.

The master branch now contains a bunch of development experience improvements.

We have a Slack to discuss development. Please reach out if you're interested to collaborate.
It's still quite early to say but I think we have a critical mass of invested maintainers.

@zachguo
Copy link
Contributor

zachguo commented May 26, 2020

👍
Is it possible to release a final v1 release before the new development related to Styletron?

@gaurav5430
Copy link

I can see that the deprecation warning has been removed 🎉 . Does this mean that active development is going to start again?

I had started looking for other alternatives like recharts, victory, but if react-vis is not going to be deprecated anymore, I would probably continue with it.

Is there a roadmap with future plans?
specifically in terms of supporting react 17?

@chrisirhc
Copy link
Contributor Author

Unfortunately, the work that was going on lost steam, so there's no current work being planned for the library.
The project needs contributors for it to move forward.

@ShaneHudson
Copy link

Could this remain pinned? Maybe mentioned in README? It's quite important information when deciding which library to use.

@yushanwebdev
Copy link

@chrisirhc I like to be a maintainer for this project.

@yushanwebdev
Copy link

@chrisirhc can we have a discussion about this library development?

@ArthurHVS
Copy link

Watching the discussion. And i can help too!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests