Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Grammar in assertion messages is not valid English. #111

Closed
denbeigh2000 opened this issue Apr 22, 2016 · 1 comment
Closed

Grammar in assertion messages is not valid English. #111

denbeigh2000 opened this issue Apr 22, 2016 · 1 comment
Assignees
@denbeigh2000

Comments

@denbeigh2000
Copy link
Contributor

Example: Failed: Expected <method> to be called 1 time but was called 0 times on <object> with any args, but was not.

Let's do something slightly more grammatically valid that is easy to generate from our existing functions.

Possibly something like: Failed: Expected <method> to be called 1 time instead of 0 times on <object> with any args, but was not.
@denbeigh2000 denbeigh2000 self-assigned this Apr 22, 2016
@denbeigh2000 denbeigh2000 mentioned this issue Apr 22, 2016
Merged
@denbeigh2000
Copy link
Contributor Author

github is hard. Use #112

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@denbeigh2000 denbeigh2000

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@denbeigh2000