Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support newer scikit-learn versions #619

Closed
pavelzw opened this issue May 22, 2023 · 6 comments
Closed

Support newer scikit-learn versions #619

pavelzw opened this issue May 22, 2023 · 6 comments
Labels
bug Something isn't working

Comments

@pavelzw
Copy link

pavelzw commented May 22, 2023

Currently this package is pinned to scikit-learn<=1.0.2. In conda-forge, there is no build for python3.11 for scikit-learn<=1.0.2 resulting in the bump to python3.11 to fail in conda-forge, see here. It would be nice to keep the dependencies of this package up to date.

❯ micromamba search scikit-learn | grep py311
 scikit-learn 1.2.2        py311h67c5ca5_0                 conda-forge/linux-64
 scikit-learn 1.2.2        py311h103fc68_1                 conda-forge/linux-64
 scikit-learn 1.2.1        py311h67c5ca5_0                 conda-forge/linux-64
 scikit-learn 1.2.0        py311h67c5ca5_0                 conda-forge/linux-64
 scikit-learn 1.1.3        py311h3b52e38_1                 conda-forge/linux-64
@pavelzw pavelzw added the bug Something isn't working label May 22, 2023
@pavelzw
Copy link
Author

pavelzw commented Jul 10, 2023

A similar problem can arise with the numpy <1.24 and pandas <1.4.0 pins from 0.14.

@ras44
Copy link
Collaborator

ras44 commented Jul 13, 2023

@pavelzw have you tried building from source and modifying dependencies pyproject.toml?

@pavelzw
Copy link
Author

pavelzw commented Jul 13, 2023

Yes, it failed during the build.

@ras44
Copy link
Collaborator

ras44 commented Jul 13, 2023

Unfortunately scikit removed Stack and StackRecord starting in v1.1.X
See

https://github.com/scikit-learn/scikit-learn/blob/1.0.X/sklearn/tree/_utils.pxd

https://github.com/scikit-learn/scikit-learn/blob/1.1.X/sklearn/tree/_utils.pxd

These are used to build trees and would probably require a rewrite of _buidler.pyx.

@ras44
Copy link
Collaborator

ras44 commented Oct 23, 2023

@jeongyoonlee is this resolved given #686?

@jeongyoonlee
Copy link
Collaborator

Closing this as it's resolved by #686.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants