Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extract methods in StreamNullabilityPropagator #944

Closed
msridhar opened this issue Mar 26, 2024 · 1 comment · Fixed by #985
Closed

Extract methods in StreamNullabilityPropagator #944

msridhar opened this issue Mar 26, 2024 · 1 comment · Fixed by #985
Labels
cleanup good first issue

Comments

@msridhar
Copy link
Collaborator 

          Not for this PR, but wonder if as a follow up you want to extract the other two cases of this if into their own methods too, with `onMatchMethodInvocation(...)` as just a dispatcher.

Originally posted by @lazaroclapp in #938 (comment)
@msridhar msridhar mentioned this issue Mar 26, 2024
Merged
@etrandafir93 etrandafir93 mentioned this issue Jun 20, 2024
Merged
@etrandafir93
Copy link
Contributor

hello @msridhar, if this is still needed - I have created a small PR and applied the changes suggested in the initial review.

If you have time to take a look, let me know what you think!
Cheers, Emanuel

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
cleanup good first issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Features/944 tidy stream nullability propagator etrandafir93/NullAway
2 participants
@msridhar @etrandafir93