From efeb150fe2c28779b03b1341583057b4128578af Mon Sep 17 00:00:00 2001 From: Joe White Date: Wed, 24 Jun 2020 09:41:52 -0400 Subject: [PATCH 1/3] Fix bugs in definition of job fact tables. Dimensions can never be null. Update typo in comment fields. --- configuration/etl/etl_tables.d/jobs/xdw/jobfact_by_.json | 6 +++--- configuration/etl/etl_tables.d/jobs/xdw/jobfact_by_day.json | 6 +++--- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/configuration/etl/etl_tables.d/jobs/xdw/jobfact_by_.json b/configuration/etl/etl_tables.d/jobs/xdw/jobfact_by_.json index 57330dd3bc..4a03d977a0 100644 --- a/configuration/etl/etl_tables.d/jobs/xdw/jobfact_by_.json +++ b/configuration/etl/etl_tables.d/jobs/xdw/jobfact_by_.json @@ -157,8 +157,8 @@ { "name": "processorbucket_id", "type": "int(4)", - "comment": "FACT: Pre-determined processor bucket sizes. References processorbucket.id", - "nullable": true + "comment": "DIMENSION: Pre-determined processor bucket sizes. References processorbucket.id", + "nullable": false }, { "name": "gpu_count", @@ -169,7 +169,7 @@ { "name": "gpubucket_id", "type": "int(11)", - "nullable": true, + "nullable": false, "comment": "DIMENSION: Pre-determined GPU bucket sizes. References gpu_buckets.id" }, { diff --git a/configuration/etl/etl_tables.d/jobs/xdw/jobfact_by_day.json b/configuration/etl/etl_tables.d/jobs/xdw/jobfact_by_day.json index 371d09ec11..2864ab9155 100644 --- a/configuration/etl/etl_tables.d/jobs/xdw/jobfact_by_day.json +++ b/configuration/etl/etl_tables.d/jobs/xdw/jobfact_by_day.json @@ -163,8 +163,8 @@ { "name": "processorbucket_id", "type": "int(4)", - "comment": "FACT: Pre-determined processor bucket sizes. References processorbucket.id", - "nullable": true + "comment": "DIMENSION: Pre-determined processor bucket sizes. References processorbucket.id", + "nullable": false }, { "name": "gpu_count", @@ -175,7 +175,7 @@ { "name": "gpubucket_id", "type": "int(11)", - "nullable": true, + "nullable": false, "comment": "DIMENSION: Pre-determined GPU bucket sizes. References gpu_buckets.id" }, { From a4660e8de3e41de134038a1aa509a4f667c0e3fb Mon Sep 17 00:00:00 2001 From: Joe White Date: Wed, 24 Jun 2020 10:27:15 -0400 Subject: [PATCH 2/3] Update configuration/etl/etl_tables.d/jobs/xdw/jobfact_by_.json Co-authored-by: Jeffrey T. Palmer --- configuration/etl/etl_tables.d/jobs/xdw/jobfact_by_.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configuration/etl/etl_tables.d/jobs/xdw/jobfact_by_.json b/configuration/etl/etl_tables.d/jobs/xdw/jobfact_by_.json index 4a03d977a0..d3429cf429 100644 --- a/configuration/etl/etl_tables.d/jobs/xdw/jobfact_by_.json +++ b/configuration/etl/etl_tables.d/jobs/xdw/jobfact_by_.json @@ -157,7 +157,7 @@ { "name": "processorbucket_id", "type": "int(4)", - "comment": "DIMENSION: Pre-determined processor bucket sizes. References processorbucket.id", + "comment": "DIMENSION: Pre-determined processor bucket sizes. References processor_buckets.id", "nullable": false }, { From 77e9b2d24732701be59a322a0e2288789a2e9fc7 Mon Sep 17 00:00:00 2001 From: Joe White Date: Wed, 24 Jun 2020 10:27:24 -0400 Subject: [PATCH 3/3] Update configuration/etl/etl_tables.d/jobs/xdw/jobfact_by_day.json Co-authored-by: Jeffrey T. Palmer --- configuration/etl/etl_tables.d/jobs/xdw/jobfact_by_day.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configuration/etl/etl_tables.d/jobs/xdw/jobfact_by_day.json b/configuration/etl/etl_tables.d/jobs/xdw/jobfact_by_day.json index 2864ab9155..578f53d28a 100644 --- a/configuration/etl/etl_tables.d/jobs/xdw/jobfact_by_day.json +++ b/configuration/etl/etl_tables.d/jobs/xdw/jobfact_by_day.json @@ -163,7 +163,7 @@ { "name": "processorbucket_id", "type": "int(4)", - "comment": "DIMENSION: Pre-determined processor bucket sizes. References processorbucket.id", + "comment": "DIMENSION: Pre-determined processor bucket sizes. References processor_buckets.id", "nullable": false }, {