From 2aa93b03498b79c2cd1e469dd0d6def4871b9999 Mon Sep 17 00:00:00 2001 From: commenthol Date: Thu, 25 May 2017 13:47:54 +0900 Subject: [PATCH] [#136] Fixing detection error for Lumia --- regexes.yaml | 2 +- tests/test_device.yaml | 6 ++++++ 2 files changed, 7 insertions(+), 1 deletion(-) diff --git a/regexes.yaml b/regexes.yaml index ff53db09..d97ecb06 100644 --- a/regexes.yaml +++ b/regexes.yaml @@ -4264,7 +4264,7 @@ device_parsers: ######### # Noka Windows Phones ######### - - regex: 'Windows Phone [^;]+; .*?IEMobile/[^;\)]+[;\)] ?(?:ARM; ?Touch; ?|Touch; ?)?(?:NOKIA|Nokia)[^;]*; *(?:NOKIA ?|Nokia ?|LUMIA ?|[Ll]umia ?)*(\d{3,}[^;\)]*)' + - regex: 'Windows Phone [^;]+; .*?IEMobile/[^;\)]+[;\)] ?(?:ARM; ?Touch; ?|Touch; ?)?(?:rv:11; )?(?:NOKIA|Nokia)[^;]*; *(?:NOKIA ?|Nokia ?|LUMIA ?|[Ll]umia ?)*(\d{3,}[^;\)]*)' device_replacement: 'Lumia $1' brand_replacement: 'Nokia' model_replacement: 'Lumia $1' diff --git a/tests/test_device.yaml b/tests/test_device.yaml index 7057c593..b3572d4d 100644 --- a/tests/test_device.yaml +++ b/tests/test_device.yaml @@ -79989,3 +79989,9 @@ test_cases: family: 'Spider' brand: 'Spider' model: 'Desktop' + + - user_agent_string: 'Mozilla/5.0 (compatible; MSIE 10.0; Windows Phone 8.0; Trident/6.0; IEMobile/10.0; ARM; Touch; rv:11; NOKIA; Lumia 920) like Gecko' + family: 'Lumia 920' + brand: 'Nokia' + model: 'Lumia 920' +