This repository has been archived by the owner on May 4, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 31
Animate priority notifications [nice-to-have] #499
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vertein
approved these changes
Aug 22, 2017
@@ -109,7 +109,7 @@ define(['angular', 'require'], function(angular, require) { | |||
|
|||
if (vm.user.firstName || vm.user.displayName) { | |||
vm.username = vm.user.firstName ? | |||
vm.user.firstName : vm.user.displayName; | |||
vm.user.firstName.toLowerCase() : vm.user.displayName.toLowerCase(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's this about?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's necessary to change the case of the username in the menu. It has to be programmatically changed to lowercase because the CSS text-transform: capitalize
has no effect on capital letters. I figured using this with CSS is less overkill than making a custom filter.
davidmsibley
approved these changes
Aug 22, 2017
ChristianMurphy
approved these changes
Aug 22, 2017
apetro
approved these changes
Aug 22, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MUMUP-3006: "As a user, I'd like a smoother experience when dismissing priority notifications, so that I can see the action happening, rather than just a disappearing bar."
In this PR:
Demo
Screenshots
Priority notifications
Modal depth fix
Username menu
Contributor License Agreement adherence: