Skip to content
This repository has been archived by the owner on May 4, 2022. It is now read-only.

Animate priority notifications [nice-to-have] #499

Merged
merged 9 commits into from
Aug 22, 2017

Conversation

thevoiceofzeke
Copy link
Contributor

@thevoiceofzeke thevoiceofzeke commented Aug 22, 2017

MUMUP-3006: "As a user, I'd like a smoother experience when dismissing priority notifications, so that I can see the action happening, rather than just a disappearing bar."

In this PR:

  • Added animations for appearance/dismissal of priority notifications
  • Adjusted design of priority notifications to be more attractive (hopefully)
  • Made a little more room for options buttons in app-header
  • Adjusted some z-indexes so not to overlay Angular Material modals
  • Adjusted confusing CSS dealing with fixed-positioned elements
  • Username in user menu no longer all caps, first letter capitalized instead
  • Added LESS variables for 5 levels of depth (per material design)
  • Renamed some LESS variables so not to tie them to specific HTML elements

Demo

notifications-demo

Screenshots

Priority notifications

screen shot 2017-08-22 at 1 25 08 pm

Modal depth fix

screen shot 2017-08-22 at 10 58 44 am

Username menu

screen shot 2017-08-22 at 10 21 07 am


Contributor License Agreement adherence:

@thevoiceofzeke thevoiceofzeke changed the title Animate priority notifications Animate priority notifications [nice-to-have] Aug 22, 2017
@@ -109,7 +109,7 @@ define(['angular', 'require'], function(angular, require) {

if (vm.user.firstName || vm.user.displayName) {
vm.username = vm.user.firstName ?
vm.user.firstName : vm.user.displayName;
vm.user.firstName.toLowerCase() : vm.user.displayName.toLowerCase();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's this about?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's necessary to change the case of the username in the menu. It has to be programmatically changed to lowercase because the CSS text-transform: capitalize has no effect on capital letters. I figured using this with CSS is less overkill than making a custom filter.

@thevoiceofzeke thevoiceofzeke merged commit 1890e31 into uPortal-Attic:master Aug 22, 2017
@davidmsibley davidmsibley modified the milestone: 5.0.0 Aug 24, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants