Fixing trivial ESLint checks #429
Conversation
Further improve depth of elements
Replace most fa-icons with material
Fix md-menu forcing scroll when priority notifications visible
package.json
Outdated
| "max-len": "warn", | ||
| "promise/catch-or-return": "warn", | ||
| "promise/always-return": "warn", | ||
|
|
There was a problem hiding this comment.
These are the list of rules that have the most violations. With the misc violations fixed, we can go through one by one to fix these.
package.json
Outdated
| @@ -104,7 +104,7 @@ | |||
| "eslintConfig": { | |||
| "root": true, | |||
| "parserOptions": { | |||
| "ecmaVersion": 5 | |||
| "ecmaVersion": 6 | |||
There was a problem hiding this comment.
What was causing errors parsing with the ES5 standard?
There was a problem hiding this comment.
almost everything is ES5 except tools/uw-frame-static/build.js
There was a problem hiding this comment.
and unfortunately I can't change versions of the parser per file, it's a project level thing.
There was a problem hiding this comment.
Parser can be changed per folder.
an .eslintrc.yml or .eslintrc.json file in a folder will override project level configuration.
There was a problem hiding this comment.
also configurations are merged, so only the parserOptions property would need to be set.
Fixing the grab bag of style misgivings, and pulling in the changes from master.
Contributor License Agreement adherence: