This repository has been archived by the owner on May 4, 2022. It is now read-only.
Enable material icons for directives and app entries #410
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChristianMurphy
approved these changes
Apr 24, 2017
thevoiceofzeke
changed the title
|
👍 |
apetro
suggested changes
Apr 25, 2017
| @@ -1,6 +1,9 @@ | |||
| <md-subheader role="heading" class="app-header"> | |||
| <h1 flex="50" flex-xs="85" class="app-title"> | |||
| <i class="fa {{::icon}}" aria-hidden="true"></i> {{::title}}</h1> | |||
| <i ng-if="icon.indexOf('fa-') > -1" class="fa {{::icon}}" aria-hidden="true"></i> | |||
| <md-icon ng-if="icon.indexOf('fa-') <= -1">{{ ::icon }}</md-icon> | |||
There was a problem hiding this comment.
I think this needs an aria-label. Maybe an aria-label of "" to get the aria-hidden="true" behavior.
apetro
approved these changes
Apr 25, 2017
vertein
approved these changes
Apr 25, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MUMUP-2781
Scope of this story: If an entity file for an app specifies an
mdIconparameter, it should be used everywhere that app icons are used. Likewise, uw-frame app developers should be able to use material icons in theframe-pageorapp-headerdirectives.In this PR:
Demo screenshots