This repository has been archived by the owner on May 4, 2022. It is now read-only.
MUMUP-2898 Adds ability to write your own directive for removing a widget #393
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
ChristianMurphy
approved these changes
Apr 12, 2017
davidmsibley
approved these changes
Apr 12, 2017
| @@ -3,7 +3,7 @@ | |||
| <!-- OPTION-LINK ICON --> | |||
| <div class="option-link-icon"> | |||
| <a href="{{ widget.selectedUrl }}" target="_blank" rel="noopener noreferrer"> | |||
| <frame-widget-icon></frame-widget-icon> | |||
| <widget-icon></widget-icon> | |||
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As far as the app-framework is concerned, widgets don't need to be removed, they only need to be rendered. Removal is more for apps that have layouts (like uPortal-home), so this allows the apps using the app-framework to have a removal button and decide what the removal actually does for widgets.
Contributor License Agreement adherence: