From ae8d090cb49fdbfea75f4577cf73a0b5562dd62f Mon Sep 17 00:00:00 2001 From: Andrew Petro Date: Wed, 11 Jul 2018 13:35:13 -0500 Subject: [PATCH 1/2] fix: rm app directory search results count badge, temporarily Mitigates bug in which the badge indicates more results than are visible to user, hypothesis: because it's counting items on which user has BROWSE but not SUBSCRIBE whereas actual results listing is only showing items on which user has both. Intended as temporary workaround. Suppresses a misleading badge until can develop a deeper fix to reliably show the correct number in the badge. --- web/src/main/webapp/my-app/search/partials/search-results.html | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/web/src/main/webapp/my-app/search/partials/search-results.html b/web/src/main/webapp/my-app/search/partials/search-results.html index 7ae23248f..2f169dc05 100644 --- a/web/src/main/webapp/my-app/search/partials/search-results.html +++ b/web/src/main/webapp/my-app/search/partials/search-results.html @@ -85,7 +85,7 @@ - {{ portal.theme.title }}  {{ appDirectoryResultsBadge }} + {{ portal.theme.title }} From e07eec6bef479ca9db7ba30085590fc8dbb57e2c Mon Sep 17 00:00:00 2001 From: Andrew Petro Date: Wed, 11 Jul 2018 13:51:55 -0500 Subject: [PATCH 2/2] docs(changelog): note rm app directory search results badge, temporarily --- CHANGELOG.md | 3 +++ 1 file changed, 3 insertions(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index 8400e06b7..4057240d9 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -18,6 +18,9 @@ and this project adheres to ### Fixed +* Removes app directory search results count badge. Intended as temporary + mitigation for bug wherein the badge did not reliably show a correct count. + (#843) * Successfully launch searches into today.wisc.edu from Madison's theme (#829) * May have fixed a bug where app directory search result badge could get out of sync with the number of search results actually being displayed. (#827)