Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Granular placeholder settings for dynamic filtering #50

Closed
5 of 6 tasks
Metaception opened this issue May 27, 2018 · 11 comments
Closed
5 of 6 tasks

Granular placeholder settings for dynamic filtering #50

Metaception opened this issue May 27, 2018 · 11 comments
Labels
duplicate This issue or pull request already exists

Comments

@Metaception
Copy link

Metaception commented May 27, 2018

Prerequisites

  • I verified that this is not a filter issue
  • This is not a support issue or a question
  • I performed a cursory search of the issue tracker to avoid opening a duplicate issue
    • Your issue may already be reported.
  • I tried to reproduce the issue when... Feature request, not a bug
  • I am running the latest version of uBlock Origin
  • I checked the documentation to understand that the issue I report is not a normal behavior

Description

The current Hide placeholders of blocked elements setting applies to all network requests. However, with a global block of 3rd-party iframe, I am finding it difficult to notice when the block is breaking a site as the space occupied by the iframe is hidden. I presume similar logic applies to 3rd-party script and image.

I would like to suggest more granularity in placeholder settings to show placeholders for certain class of filters while hiding the rest. Forgive me if this is not technically feasible or I am misunderstanding something.

A specific URL where the issue occurs

https://priceonomics.com/introducing-priceonomics-charts/

Your environment

  • uBlock Origin version: 1.16.8
  • Browser Name and version: Firefox 60.0.1
  • Operating System and version: Windows 10
@uBlock-user uBlock-user added the enhancement New feature or request label May 27, 2018
@uBlock-user
Copy link
Contributor

gorhill/uBlock#2688

Is that what you're suggesting ?

@Metaception
Copy link
Author

Metaception commented May 27, 2018

Kinda related, but not the same feature.
That issue is asking for more visible placeholders to help with identifying blocked features.

I am OK with the blank placeholders that currently exist, but I would like to show only some of them. Currently, if you set uBlock to show placeholders, you can see the missing iframes, but you will also see blocked image ads taking space too.

I was hoping that a more granular setting will allow the ads to be collapsed, while allowing the iframes to show a placeholder.

@uBlock-user
Copy link
Contributor

uBlock-user commented May 27, 2018

Currently, if you set uBlock to show placeholders, you can see the missing iframes, but you will also see blocked image ads taking space too.

Where? There are no blank placeholders in uBlock Origin, that's why it was suggested to add them to uBO too, just like uMatrix has them. The ones you do see when you untick Hide placeholders of blocked elements is from browser, by activating that setting, uBO hides it from appearing.

Although, what you're suggesting can be done by differentiating ads and blocked iframes in two categories as blacklisted elements and blocked elements.

Blacklisted elements could be those which are blocked by a filter rule, if found, so in this case ads and trackers.

Blocked elements could be those which are blocked by Dynamic Filtering, so in this case iframes.

@Metaception
Copy link
Author

Metaception commented May 27, 2018

Blank as in just empty space that is not collapsed.
You can test in the link provided, disabling Hide Placeholders show more space.

The ones you do see when you untick Hide placeholders of blocked elements is from browser, by activating that setting, uBO hides it from appearing.

Yes, I am content with the default placeholders. Perhaps I should have called them default or empty instead.

@gwarser
Copy link

gwarser commented May 27, 2018

Where

Firefox

@Metaception
Copy link
Author

Although, what you're suggesting can be done by differentiating ads and blocked iframes in two categories as blacklisted elements and blocked elements.

That was my thought as well. However, I left the implementation details vague in case further granularity would be desirable such as separate settings for images, scripts, and iframes.

I was unsure how useful that would be though, as I only block iframes.

@uBlock-user
Copy link
Contributor

Firefox

A screenshot would expand on that better.

@Metaception
Copy link
Author

Would you like me to provide a picture?
It just be me toggling the Hide Placeholder setting though.

Or are you asking what @gwarser meant?

@gorhill
Copy link
Member

gorhill commented May 27, 2018

Duplicate of gorhill/uBlock#3619.

@Metaception
Copy link
Author

Metaception commented May 27, 2018

Ohhhh, so uMatrix already has this so this shouldn't be too far-fetched.

From what I can tell settings.html needs a collapseBlacklisted setting and all the translations need a update. background.js needs collapseBlacklisted added too. These two seems straightforward.

But, it looks like uBlock just collapses any collapsible requests right now while uMatrix actually checks against the domains. This is beyond me rip.

@uBlock-user uBlock-user added the duplicate This issue or pull request already exists label May 27, 2018
@gwarser
Copy link

gwarser commented May 27, 2018

@uBlock-user
screenshot_20180527_193228

@uBlock-user uBlock-user changed the title Request: Granular placeholder settings for dynamic filtering Granular placeholder settings for dynamic filtering Jun 30, 2018
@uBlock-user uBlock-user removed the enhancement New feature or request label Dec 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
duplicate This issue or pull request already exists
Projects
None yet
Development

No branches or pull requests

4 participants