-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Granular placeholder settings for dynamic filtering #50
Comments
Is that what you're suggesting ? |
Kinda related, but not the same feature. I am OK with the blank placeholders that currently exist, but I would like to show only some of them. Currently, if you set uBlock to show placeholders, you can see the missing iframes, but you will also see blocked image ads taking space too. I was hoping that a more granular setting will allow the ads to be collapsed, while allowing the iframes to show a placeholder. |
Where? There are no blank placeholders in uBlock Origin, that's why it was suggested to add them to uBO too, just like uMatrix has them. The ones you do see when you untick Hide placeholders of blocked elements is from browser, by activating that setting, uBO hides it from appearing. Although, what you're suggesting can be done by differentiating ads and blocked iframes in two categories as
|
Blank as in just empty space that is not collapsed.
Yes, I am content with the default placeholders. Perhaps I should have called them default or empty instead. |
Firefox |
That was my thought as well. However, I left the implementation details vague in case further granularity would be desirable such as separate settings for images, scripts, and iframes. I was unsure how useful that would be though, as I only block iframes. |
A screenshot would expand on that better. |
Would you like me to provide a picture? Or are you asking what @gwarser meant? |
Duplicate of gorhill/uBlock#3619. |
Ohhhh, so uMatrix already has this so this shouldn't be too far-fetched. From what I can tell But, it looks like uBlock just collapses any collapsible requests right now while uMatrix actually checks against the domains. This is beyond me rip. |
Prerequisites
I tried to reproduce the issue when...Feature request, not a bugDescription
The current Hide placeholders of blocked elements setting applies to all network requests. However, with a global block of 3rd-party
iframe
, I am finding it difficult to notice when the block is breaking a site as the space occupied by theiframe
is hidden. I presume similar logic applies to 3rd-partyscript
andimage
.I would like to suggest more granularity in placeholder settings to show placeholders for certain class of filters while hiding the rest. Forgive me if this is not technically feasible or I am misunderstanding something.
A specific URL where the issue occurs
https://priceonomics.com/introducing-priceonomics-charts/
Your environment
The text was updated successfully, but these errors were encountered: