Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please adjust colors to something color-blind people can see #3033

Closed
7 tasks done
davimack opened this issue Dec 19, 2023 · 5 comments
Closed
7 tasks done

Please adjust colors to something color-blind people can see #3033

davimack opened this issue Dec 19, 2023 · 5 comments
Labels
invalid not a uBlock issue

Comments

@davimack
Copy link

Prerequisites

I tried to reproduce the issue when...

  • uBO is the only extension.
  • using a new, unmodified browser profile.

Description

When you click the uBlock icon you get a dashboard popup. This has a list of domains & how they're treated. The indicators are red and green. Wikipedia tells me I'm not alone in not being able to see those colors. Red–green color blindness affects up to 1 in 12 males (8%) and 1 in 200 females (0.5%).

A specific URL where the issue occurs.

https://www.google.com/

Steps to Reproduce

  1. Click the plugin from the browser bar.
  2. Look at the red and green things.
  3. Imagine that one of those looks sort of puke colored, and the other you can only see if you zoom in.
  4. Wonder whether the feature would be useful if I could see it.

Expected behavior

I'm asking to pretty please pick some different colors. Probably not yellow/blue either, as there's a type of color blindness for those colors as well.
image

Actual behavior

It was colors I can't see.

Configuration

uBlock Origin: 1.54.0
Chromium: 120
filterset (summary):
 network: 107534
 cosmetic: 88165
 scriptlet: 22898
 html: 0
listset (total-discarded, last-updated):
 added:
  fanboy-cookiemonster: 49101-163, 1d.35m
 default:
  user-filters: 34-0, never
  easylist: 75913-16, 3h.51m
  easyprivacy: 33118-65, 3h.51m
  plowe-0: 3777-1148, 9d.3h.43m
  ublock-badware: 7633-138, 3h.51m
  ublock-filters: 36435-358, 3h.51m
  ublock-privacy: 949-12, 3h.51m
  ublock-quick-fixes: 100-5, 3h.51m
  ublock-unbreak: 2176-33, 3h.51m
  urlhaus-1: 11445-0, 1h.51m
filterset (user): [array of 34 redacted]
trustedset:
 added: [array of 22 redacted]
 removed:
  chrome-scheme
userSettings: [none]
hiddenSettings: [none]
supportStats:
 allReadyAfter: 1594 ms (selfie)
 maxAssetCacheWait: 397 ms
@gwarser
Copy link

gwarser commented Dec 19, 2023

Is this better?

image

https://github.com/uBlockOrigin/uBlock-issues/wiki/Dashboard:-Settings#color-blind-friendly

@davimack
Copy link
Author

I see what you're showing me, in the colors with + and - in them? I don't think that's out yet, though, or it's a setting? It's entirely possible that this solves it, yes, once I've learned what the colors mean. 😄 I'll poke through settings & see if I can find this in there. Thank you!

(funny for you: I created a spreadsheet with tons of the "green" codes, so I could flag the ones I can't see & never use them on applications.)

@u-RraaLL
Copy link
Contributor

or it's a setting?

uBO's popup > Dashboard > Settings > Appearance > [x] Color-blind friendly

@gorhill
Copy link
Member

gorhill commented Dec 20, 2023

This was implemented in April 2015: uBlock-LLC/uBlock#467 (comment).

Additionally, the pluses/minuses convey the same information.

@gwarser gwarser added the invalid not a uBlock issue label Dec 20, 2023
@gwarser gwarser closed this as completed Dec 20, 2023
@garry-ut99

This comment was marked as abuse.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
invalid not a uBlock issue
Projects
None yet
Development

No branches or pull requests

5 participants