Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redirect Rule Functionality #2849

Closed
8 tasks done
KiARC opened this issue Oct 3, 2023 · 4 comments
Closed
8 tasks done

Redirect Rule Functionality #2849

KiARC opened this issue Oct 3, 2023 · 4 comments
Labels
declined declined duplicate This issue or pull request already exists

Comments

@KiARC
Copy link

KiARC commented Oct 3, 2023

Prerequisites

  • I verified that this is not a filter list issue. Report any issues with filter lists or broken website functionality in the uAssets issue tracker.
  • This is not a support issue or a question. For support, questions, or help, visit /r/uBlockOrigin.
  • I performed a cursory search of the issue tracker to avoid opening a duplicate issue.
  • The issue is not present after disabling uBO in the browser.
  • I checked the documentation to understand that the issue I am reporting is not normal behavior.

I tried to reproduce the issue when...

  • uBO is the only extension.
  • uBO uses default lists and settings.
  • using a new, unmodified browser profile.

Description

Enable My Filters static rules to rewrite requests, i.e. from ajax.googleapis.com/ajax/libs/jquery/<path> to cdnjs.cloudflare.com/ajax/libs/jquery/<path>

A specific URL where the issue occurs.

https://dontkillmyapp.com/google

Steps to Reproduce

  1. Visit the website, with * * 3p-script block in My Rules and no overrides for ajax.googleapis.com/ajax/libs/jquery
  2. Open Logger, reload page
  3. See that the request has been blocked, and as such parts of the page do not function

Expected behavior

I would like to be able to add a rule to My Filters that rewrites the URL:
ajax.googleapis.com/ajax/libs/jquery/<path> -> cdnjs.cloudflare.com/ajax/libs/jquery/<path>
Because I would like to minimize my requests to Google. I am aware that this has been rejected on grounds of potential privacy/security risks from malicious list maintainers, which is why I propose that this only work when the rule exists in My Filters rather than an external subscribed list.

Actual behavior

This functionality does not exist.

uBO version

1.52.2

Browser name and version

Firefox Nightly 119.0b4

Operating System and version

Windows 11

@KiARC
Copy link
Author

KiARC commented Oct 3, 2023

For the record, I tried simply doing this with a Redirect rule in Request Control, but unfortunately that extension has very poor documentation, and additionally uBO blocks the request before Request Control can rewrite it, even if the latter was installed first. This seems to be an issue with the fact that the order in which Firefox extensions are loaded is inconsistent. Regardless, in my opinion this would be a meaningful addition to uBO on virtue of allowing users to more easily avoid untrustworthy CDNs in favor of those they trust, which I feel falls into the same line of thinking that uBO is based on: Blocking/defusing content that the user wishes to avoid.

@uBlock-user
Copy link
Contributor

I would like to be able to add a rule to My Filters that rewrites the URL:

Duplicate of #46

@uBlock-user uBlock-user added the duplicate This issue or pull request already exists label Oct 4, 2023
@KiARC
Copy link
Author

KiARC commented Oct 4, 2023

I don't think this is a duplicate. The core functionality is the same but I specifically pointed out a different way to implement it than the one proposed in #46

@gorhill gorhill added the declined declined label Oct 4, 2023
@uBlock-user
Copy link
Contributor

uBlock-user commented Oct 4, 2023

The core functionality is the same but I specifically pointed out a different way to implement it than the one proposed

You suggesting a restrictive functionality from what has been suggested before, doesn't change it from being a duplicate. It was declined before and has been declined again.


As per your specific case, you should start using localCDN, it goes one step further and prevents un-necessary connections to CDNs at all.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
declined declined duplicate This issue or pull request already exists
Projects
None yet
Development

No branches or pull requests

3 participants