Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HTML filter is not applied just after allowance if strict-blocking is temporary allowed #1507

Open
6 of 8 tasks
Yuki2718 opened this issue Feb 23, 2021 · 5 comments
Open
6 of 8 tasks
Labels
bug Something isn't working Firefox-Android specific to Android platform

Comments

@Yuki2718
Copy link

Yuki2718 commented Feb 23, 2021

Prerequisites

  • I verified that this is not a filter issue
  • This is not a support issue or a question
  • I performed a cursory search of the issue tracker to avoid opening a duplicate issue
    • Your issue may already be reported.
  • I tried to reproduce the issue when...
    • uBlock Origin is the only extension
    • uBlock Origin with default lists/settings
    • using a new, unmodified browser profile
  • I am running the latest version of uBlock Origin
  • I checked the documentation to understand that the issue I report is not a normal behavior

Description

It may be only me but as the title says a HTML filter is skipped just after temporal allowing of strict-blocking. Reload and the filter is correctly applied, or as long as temporal allowance is on the filter is applied - it's only just after the first allowance. If I disable the filter causing strict-blocking, again the filter is applied. And it's only on Android.

A specific URL where the issue occurs

Google search https://www.google.com/search?client=firefox-b-d&q=nanj-adguard&oq=nanj-adguard -> go to https://wikiwiki.jp/nanj-adguard/. Tested on a few other URLs too.

Steps to Reproduce

  1. Add any valid HTML filter and any rule to cause strict-blocking, for example wikiwiki.jp##^.title2 and ||wikiwiki.jp^$doc
  2. Open the logger, visit the site, and temporary allow.
  3. See HTML filter was not applied but applied if the page is reloaded.

Expected behavior:

HTML filter is applied whatever condition is.

Actual behavior:

Not

Your environment

  • uBlock Origin version: 1.33.2
  • Browser Name and version: Firefox 85.1.3 (Build #2015792283)
  • Operating System and version: Android 11
@gwarser gwarser added the unable to reproduce cannot reproduce the issue label Feb 23, 2021
@gwarser
Copy link

gwarser commented Feb 23, 2021

Fx 85.0.2/86.0 uBO 1.33.2 on Manjaro - unable to reproduce.

@uBlock-user
Copy link
Contributor

Can you repro this consistently ?

@Yuki2718
Copy link
Author

Yuki2718 commented Feb 25, 2021

Can you repro this consistently ?

Yes, it's 100% of times and reproduced on Firefox Beta 86.0.0-beta.5 too. I don't know how to take video screenshot like ghajini so at most can upload screenshots of the logger if it ever helps.

@Yuki2718
Copy link
Author

Yuki2718 commented Feb 25, 2021

The first SS is actually the second try - temporal allowance is still active and HTML filter is applied. I waited for the allowance to be inactive cleared cache etc., tried again and temporary allowed again, then in the second screenshot the filter is not applied.

Screenshot_1

Screenshot_2

@gwarser gwarser added Firefox-Android specific to Android platform bug Something isn't working and removed unable to reproduce cannot reproduce the issue labels Feb 25, 2021
@gwarser
Copy link

gwarser commented Feb 25, 2021

I see this with remote debugging. No errors in console.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Firefox-Android specific to Android platform
Projects
None yet
Development

No branches or pull requests

3 participants