Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

old.reddit.com: nuisance #15173

Closed
7 of 8 tasks
ghost opened this issue Oct 6, 2022 · 10 comments
Closed
7 of 8 tasks

old.reddit.com: nuisance #15173

ghost opened this issue Oct 6, 2022 · 10 comments
Labels

Comments

@ghost
Copy link

ghost commented Oct 6, 2022

Prerequisites

  • I read and understood the policy as to what is a valid filter issue
  • I verified that the issue has not already been reported (use this button to find out)
  • I forced an update of my filter lists (how to do this: click "Purge all caches", then click "Update now")
  • I did not remove any of the default filter lists, or I verified that the issue is not caused by removing any of the default lists
  • I did not enable external filter lists, or I verified that the issue still occurs without enabling external filter lists
  • I do not have custom filters/rules, or I verified that the issue still occurs without custom filters/rules
  • I am not using another content blocker along uBO (also mind browser built-in blockers)
  • I did not answer truthfully to all the above checkpoints

URL address of the web page

https://old.reddit.com/r/bugs/comments/nax0lu/updates_to_post_requirements/

Category

nuisance

Describe the issue

Internal links are modified to add tracking parameters when you click on them.

AdGuard URL Tracking Protection removes tracking parameters from requests. The problem is that the full links are still added to the user's history. Since there are many internal links on Reddit, it's an annoyance to see so many history entries with utm. Please disable this script function for this specific site.

Screenshot(s)

Screenshot(s)

screenshot

Configuration

uBlock Origin: 1.44.4
Firefox: 105
filterset (summary): 
  network: 91668
  cosmetic: 91969
  scriptlet: 23964
  html: 806
listset (total-discarded, last updated): 
  added: 
    adguard-spyware-url: 781-3, now
    adguard-annoyance: 59631-764, now
    ublock-annoyances: 4869-4, now
  default: 
    user-filters: 0-0, never
    ublock-filters: 33827-47, now
    ublock-badware: 4345-0, now
    ublock-privacy: 273-0, now
    ublock-abuse: 76-0, now
    ublock-unbreak: 1879-2, now
    ublock-quick-fixes: 337-0, now
    easylist: 62462-622, now
    easyprivacy: 30694-1706, now
    urlhaus-1: 8871-0, now
    plowe-0: 3672-3, now
filterset (user): [empty]
modifiedUserSettings: [none]
modifiedHiddenSettings: [none]
supportStats: 
  allReadyAfter: 4878 ms
  maxAssetCacheWait: 742 ms
popupPanel: 
  blocked: 3
  blockedDetails: 
    reddit.com: 2
    redditmedia.com: 1
@krystian3w
Copy link
Contributor

Needed investigation how is added (if exist in view-source: then needed wait to trusted scriptlet system: uBlockOrigin/uBlock-issues#2229)

Or mapx- again edit own us.js file: #14849 (comment)

@mapx-
Copy link
Contributor

mapx- commented Oct 7, 2022

I get no params on r/bugs ?!

@krystian3w
Copy link
Contributor

How?

https://old.reddit.com/r/bugs?utm_source=reddit&utm_medium=usertext&utm_name=bugs&utm_content=t3_nax0lu

@mapx-
Copy link
Contributor

mapx- commented Oct 7, 2022

Now I see only when clicking r/bugs the params are attached on fly

@MasterKia
Copy link
Member

MasterKia commented Oct 7, 2022

Test
old.reddit.com##+js(aeld, mousedown)

@mapx-
Copy link
Contributor

mapx- commented Oct 7, 2022

it seems no filter from AdGuard URL Tracking Protection is not triggered in this case, your aeld seems working, I wonder if the similar for click should be added

@krystian3w
Copy link
Contributor

The mousedown no cover mobile environment "events".

@Yuki2718
Copy link
Contributor

Yuki2718 commented Oct 8, 2022

On my end AGURLTP is working fine. utm attached, but on the page transition all removed (go to https://old.reddit.com/r/bugs/).

@MasterKia
Copy link
Member

The problem is that the full links are still added to the user's history. Since there are many internal links on Reddit, it's an annoyance to see so many history entries with utm.

@Yuki2718
Copy link
Contributor

Yuki2718 commented Oct 8, 2022

So it's annoyance than privacy. I don't think that's worth the risky scriptlet filter (yes, confirmed we can't narrow down that).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants