Firstly, thank you for your interest in contributing to the kotlin-quarkus-realworld-example-app project. Please read below for our contributing guidelines.
Propactive welcomes contributions from everyone. Contributions to our projects should be made in the form of GitHub pull requests. Please see the GitHub flow for further details.
By default, each change in the PR automatically runs all the tests via GitHub actions. If tests are failing, make sure to address the failures. Otherwise, you can wait for a review.
If comments have been given in a review, they have to get integrated. For those requested changes, a separate commit should be created and pushed to your remote development branch. Don’t forget to add a comment in the PR afterward, so everyone gets notified by GitHub. Keep in mind that reviews can span multiple cycles until we are happy with the new code.
- Create a new branch and, if needed, rebase to the current main branch before submitting your pull request. If it doesn't merge cleanly with main you may be asked to resolve those conflicts.
- Commits should be as small as possible, while ensuring that each commit is correct independently (i.e. each commit should compile and pass tests).
- If your patch is not getting reviewed, or you need a specific person to review it, you can @-reply a reviewer asking for a review in the pull request or a comment.
- Ensure you add tests relevant to the fixed bug or new feature, untested code is undesirable.
We follow the official Kotlin coding conventions, adhere to the Test-driven development style of programming, and are a big fan of Robert C. Martin teachings of Clean Code. If there is something unclear of the style, just look at existing code which might help you to understand it better.
We follow the GitHub Community Code of Conduct. In short, please treat GitHub Community with respect. We are a shared resource — a place to share skills, knowledge, and interests through ongoing conversation.
All code in this repository is under The MIT License.