JDK 21 - NoSuchMethodError for TreeMaker.Select

[cushon]

The signature of TreeMaker.Select is changing in the next release of the JDK (openjdk/jdk@a917fb3#diff-116d757068eaf94ea4c877b290331659678769ec5e30145f6cb5738fd5c02adcL356-R357), and this line will need to be updated:

checker-framework/javacutil/src/main/java/org/checkerframework/javacutil/trees/TreeBuilder.java

Line 122 in b11dfe5

(JCTree.JCFieldAccess) maker.Select((JCTree.JCExpression) iterableExpr, iteratorMethod);

Currently that method fails on JDK 21 with errors like:

 Exception: java.lang.NoSuchMethodError: 'com.sun.tools.javac.tree.JCTree$JCExpression com.sun.tools.javac.tree.TreeMaker.Select(com.sun.tools.javac.tree.JCTree$JCExpression, com.sun.tools.javac.code.Symbol)'; java.lang.NoSuchMethodError: 'com.sun.tools.javac.tree.JCTree$JCExpression com.sun.tools.javac.tree.TreeMaker.Select(com.sun.tools.javac.tree.JCTree$JCExpression, com.sun.tools.javac.code.Symbol)'
        at org.checkerframework.javacutil.trees.TreeBuilder.buildValueOfMethodAccess(TreeBuilder.java:392)
        at org.checkerframework.dataflow.cfg.builder.CFGTranslationPhaseOne.box(CFGTranslationPhaseOne.java:819)
        at org.checkerframework.dataflow.cfg.builder.CFGTranslationPhaseOne.commonConvert(CFGTranslationPhaseOne.java:1136)

[mernst]

@cushon Thanks for the heads-up. We test on released JDKs and so would have noticed this only in a few weeks.

[mernst]

@cushon The next release of the JDK will be JDK 20. JDK 21 will be released in September. Did you mean that the failure is on JDK 20?

[cushon]

I meant JDK 21

[mernst]

Thank you for the clarification. I was confused by the mismatch:

The signature of TreeMaker.Select is changing in the next release of the JDK
...
Currently that method fails on JDK 21 with errors like:

So the method is changing in JDK 20 and fails under JDK 21.
Do you know whether the method works under JDK 20? (If not, we can check.)

[cushon]

I believe it's only changing in JDK 21, and that the release branch for JDK 20 has already been made and does not include that change

[wendigo]

@mernst error-prone (and checker-framework) seems to work under JDK 20, but not with JDK 21 (ea 24)